Update Cypress peer dependency to 13

[marktnoonan]

Hi! Let me know if you want to wait until closer to release to merge this, I just wanted to flag that 13 is coming, I do not have a definitive release date. I have seen no problems with Testing Library in the pre-release of the new version and there's nothing that seems like it would cause a problem. Just wanted to let you know that a new major is coming soon-ish.

What:

Cypress 13 is coming soon, it will include some breaking changes to Cypress but nothing that breaks Cypress Testing Library.

Why:
Avoid peer dependency warnings when people upgrade.

How:

Checklist:

• Documentation
• Tests
• Ready to be merged
  

[davereid]

LGTM

[nrutman]

@NicholasBoll any thoughts on getting this merged by the team? It's blocking upgrades to Cypress 13 for anyone who uses Cypress Testing Library.

[Lasidar]

We are waiting on this fix as well for our upgrade to Cypress 13

[vicwomg]

Note that if you're running into issues with cypress-io/github-action , you can temporarily work around it by overriding the install command in the workflow file to ignore peer deps in the install-command parameter:

- name: Cypress e2e run
        id: cypress_e2e_run
        uses: cypress-io/[email protected]
        with:
          # Override install because Cypress upgrades break peer deps of other packages
          install-command: npm ci --legacy-peer-deps
          install: true
          browser: chrome
          # `Record: true` sends results to Cypress Dashboard
          record: true
          parallel: true

[istr]

For the time being, you might as well override the peer dependency in your root package.json. Minimal working example:

{
  "devDependencies": {
    "@testing-library/cypress": "9.0.0",
    "cypress": "13.1.0"
  },
  "overrides": {
    "@testing-library/cypress": {
      "cypress": "^13.0.0"
    }
  }
}

Dependency tree:

npm list
cyp-test-foo@ /home/istr/cyp-test-foo
├── @testing-library/[email protected] overridden
└── [email protected] overridden

[ray-peters]

Hey team, any blockers on this front? Is there anything we can do to help move this update along?

[PowerSupply]

Is this moving forwards?

[nrutman]

@NicholasBoll @kentcdodds is anything holding this up from being merged? It's preventing people from upgrading to Cypress 13 if they use your package.

[davepar]

Also hit this problem after upgrading to Cypress v13.

[nrutman]

Thank you @kentcdodds!!

[github-actions]

🎉 This PR is included in version 10.0.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

[Kocal]

Thanks for merging :)