feat(commands): use waitForElement; add jest & cypress tests #2
Conversation
@kentcdodds I apologize for this one huge commit but I wanted to make it all real, fast (in a few hours). - change commands to use `waitForElement` from `dom-testing-library` (updated to latest) - update `kcd-scripts` dependency to latest - add jest tests for basic smoke check on the exports - add cypress tests for functionality check of the commands - add npm scripts that run the tests in both development and CI environments (somewhat convoluted because cypress hasn't got enough hooks to spin up the fixture server from JavaScript; I didn't want to write a Node app so I used `serve` which needs to be killed after cypress exits but regardless of its exit code, so I used `npm-run-all` and `fkill-cli` and a combination of npm scripts with parallel/sequential execution)
| @@ -0,0 +1,2 @@ | |||
| // Keeping this file here, otherwise it gets recreated by Cypress on each run. | |||
There was a problem hiding this comment.
Yes, this is super annoying...
|
Rats. I'll work out what's going on and get this merged and released soon! |
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
|
Yay! 🎆🔥🎉 Hopefully address #3 soon. |
|
Thanks so much for your help! I've added you as a collaborator on the project. Please make sure that you review the |
@kentcdodds I apologize for this one huge commit but I wanted to make
it all real, fast (in a few hours).
waitForElementfromdom-testing-library(updated to latest)
kcd-scriptsdependency to latestenvironments (somewhat convoluted because cypress hasn't got enough
hooks to spin up the fixture server from JavaScript; I didn't want to
write a Node app so I used
servewhich needs to be killed aftercypress exits but regardless of its exit code, so I used
npm-run-alland
fkill-cliand a combination of npm scripts withparallel/sequential execution)