Move types from DefinitelyTyped

[TheGallery]

What:

Move types from DefinitelyTyped to this repository.

Why:

Reduce the amount of additional dependencies required and avoid issues like the one described here.

How:

Followed the approach taken in testing-library/react-testing-library#690 and testing-library/dom-testing-library#530

Checklist:

• Documentation
• Tests
• Ready to be merged

---

The pre-commit hook was complaining about some type definition conflicts (as mentioned here) when running tsc so I had to skip it to create the PR. I could use some help resolving that if anyone becomes available.

[kentcdodds]

Great! Just one thing

[kentcdodds]

Should this be released as a breaking change? It technically is. I'm thinking I'd we do we could also remove the query* queries because Cypress doesn't need them thanks to the special behavior of the should('not.exist') assertion. Thoughts?

[TheGallery]

Ah of course, they should be removed. I also agree this is a breaking change! I'll push this change later today.

[TheGallery]

Added as a dependency because dtslint complains without it.

[kentcdodds]

I merged this into the next branch, but it should've been beta, so I'll do a little git gymnastics and then we'll have a beta release. Also, we'll want to make any other breaking change (like removing query*). Would you like to work on that?

[kentcdodds]

Also, @TheGallery, thanks so much for your help! I've added you as a collaborator on the project. Please make sure that you review the other/MAINTAINING.md and CONTRIBUTING.md files (specifically the bit about the commit messages and the git hooks) and familiarize yourself with the code of conduct (we're using the contributor covenant). You might also want to watch the repo to be notified when someone files an issue/PR. Please continue to make PRs as you feel the need (you can make your branches directly on the repo rather than your fork if you want). Thanks! And welcome to the team :)

[TheGallery]

I merged this into the next branch, but it should've been beta, so I'll do a little git gymnastics and then we'll have a beta release. Also, we'll want to make any other breaking change (like removing query*). Would you like to work on that?

Gladly. Just to make sure, we want to remove the query* queries from the API completely instead of showing that error message?

[kentcdodds]

The migration should just be a find and replace right? unless I'm missing something. If it's just a fine and replace, then I'm not worried about just removing it in a major version.

[TheGallery]

I am pretty sure it's me missing something. I am just confused on how removing query* queries compares to this #130. I am sorry about the confusion.

[kentcdodds]

Oh yeah, I forgot about that. That didn't remove them, it deprecated them. Now we're need to remove them.

[TheGallery]

Right, I think I have a pretty good picture of what needs to be done now! I'll get to it. Thanks a bunch for the guidance.