From bd343ab0d686a6a5fae315003eb2053e77e028d1 Mon Sep 17 00:00:00 2001 From: Andy Blum Date: Wed, 1 Nov 2023 14:15:24 -0400 Subject: [PATCH] fix(link-with-icon): refactor LINK_SIZE enum (#11071) * fix(link-with-icon): refactor LINK_SIZE enum * fix(link-with-icon): export LINK_SIZE * fix(link-with-icon): change union to object-to-type * fix(link-with-icon): revert LINK_SIZE reference removals * chore(release): publish - @carbon/web-components@1.34.0-rc.0 - @carbon/eslint-config-ibmdotcom@1.44.0-rc.0 - @carbon/eslint-plugin-ibmdotcom-import-rules@1.43.0-rc.0 - @carbon/eslint-plugin-react-prop-type-comments@1.43.0-rc.0 - @carbon/ibmdotcom-react@1.53.0-rc.0 - @carbon/ibmdotcom-services-store@1.53.0-rc.0 - @carbon/ibmdotcom-services@1.53.0-rc.0 - @carbon/storybook-addon-theme@1.44.0-rc.0 - @carbon/stylelint-config-ibmdotcom@1.43.0-rc.0 - @carbon/ibmdotcom-styles@1.53.0-rc.0 - @carbon/ibmdotcom-utilities@1.53.0-rc.0 - @carbon/ibmdotcom-web-components@1.38.0-rc.0 * Revert "chore(release): publish" This reverts commit af5f295a1f32b119db9fe196a876d92d34a0eb3f. --------- Co-authored-by: ibmdotcom-bot --- .../src/components/link/link.ts | 24 +++++++------------ 1 file changed, 8 insertions(+), 16 deletions(-) diff --git a/packages/carbon-web-components/src/components/link/link.ts b/packages/carbon-web-components/src/components/link/link.ts index eb1c32b2333..bac86923f10 100644 --- a/packages/carbon-web-components/src/components/link/link.ts +++ b/packages/carbon-web-components/src/components/link/link.ts @@ -20,22 +20,14 @@ const { prefix } = settings; /** * Link size. */ -export enum LINK_SIZE { - /** - * Regular size - */ - REGULAR = '', - - /** - * Small size. - */ - SMALL = 'sm', +export const LINK_SIZE = { + REGULAR: '', + SMALL: 'sm', + LARGE: 'lg', +}; - /** - * Large size. - */ - LARGE = 'lg', -} +// Convert object key in a type +type LINK_SIZE_TYPE = (typeof LINK_SIZE)[keyof typeof LINK_SIZE]; /** * Link. @@ -190,7 +182,7 @@ class BXLink extends FocusMixin(LitElement) { * Link size. */ @property({ reflect: true }) - size = LINK_SIZE.REGULAR; + size: LINK_SIZE_TYPE = LINK_SIZE.REGULAR; /** * The link target.