Allow HTTP::Server::Context#redirect to take an URL #659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like a nice Developer Experience improvement. WDYT @straight-shoota ? |
sdogruyol
approved these changes
Sep 23, 2023
straight-shoota
approved these changes
Sep 23, 2023
sdogruyol
approved these changes
Sep 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Had a bit of a
huh?moment when I discovered that I can't redirect to an URI, but it has to be a string. So I thought#redirectmight as well take aString | URI.Alternate Designs
Could've made an overload, but this looks nicer. Think the compiler will optimize it in any case.
Benefits
Usage looks nicer.
Possible Drawbacks
Possibly a miniscule performance impact, in theory something has to check whether it's a string or URI now, but I believe the compiler is smarter than that.