Respec envconfig tag within usage #194
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should potentially fix #90, but currently the tests are failing because I haven't touched them so far. Before I fix the tests I wanted to clarify the rules.
Currently the usage functionality is entirely ignoring the custom environment keys, with my approach it's first checking if the
envconfig:""tag is set, if it is, it will just use it. I'm also transforing the tag value to uppercase as the variables seem to be uppercase all the time?Another part that is not entirely clear to me, should the
envconfig:tag ignore the prefix? AFAIK it does, but please make that clear to me :)