Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

colorful piping #9

Merged
merged 2 commits into from
Mar 2, 2015
Merged

colorful piping #9

merged 2 commits into from
Mar 2, 2015

Conversation

paulpflug
Copy link
Collaborator

fix for #7
largely copied from nodemon

fix for #7
largely copied from nodemon
process.argv.slice(2).forEach(function (childCmd) {
var child = exec(childCmd, {
cwd: process.cwd(),
console.log('spawning '+childCmd);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't console.log, IMO.

@keithamus
Copy link
Collaborator

Great work @paulpflug! Get rid of the console.log and I'll merge 🎉

removed console.log
@paulpflug
Copy link
Collaborator Author

right, forgot it ;)

done

keithamus added a commit that referenced this pull request Mar 2, 2015
@keithamus keithamus merged commit 51cddf4 into darkguy2008:master Mar 2, 2015
@paulpflug paulpflug deleted the #7 branch March 2, 2015 22:18
@mikalai-s
Copy link

@keithamus so to get this change I have to wait for next release? any plans for it?:)

@keithamus
Copy link
Collaborator

@mikalai-silivonik released as v1.1.0

estk pushed a commit to estk/parallelshell that referenced this pull request Sep 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants