Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Login dialog and 1Password confusion #3298

Open
gugrim opened this issue Dec 1, 2024 · 0 comments
Open

Login dialog and 1Password confusion #3298

gugrim opened this issue Dec 1, 2024 · 0 comments
Assignees

Comments

@gugrim
Copy link

gugrim commented Dec 1, 2024

Because of the ordering of the login button elements in the Login dialog, when 1Password in Chrome autofills, Roda switches to password recovery instead of logging in.

This HTML causes problems:

<div class="login-buttons">
    <button type="button" class="gwt-Button btn btn-link login-link">Recover password</button>
    <button type="button" class="gwt-Button btn btn-link login-link">Sign up</button>
    <button type="button" class="gwt-Button btn btn-play login-button">Login</button>
    <button type="button" class="gwt-Button btn btn-link login-link" aria-hidden="true" style="display: none;">Resend verification email</button>
</div>

By moving the login button up, 1Password works fine:

<div class="login-buttons">
    <button type="button" class="gwt-Button btn btn-play login-button">Login</button>
    <button type="button" class="gwt-Button btn btn-link login-link">Recover password</button>
    <button type="button" class="gwt-Button btn btn-link login-link">Sign up</button>
    <button type="button" class="gwt-Button btn btn-link login-link" aria-hidden="true" style="display: none;">Resend verification email</button>
</div>

Since the layout is controlled by css, the dialog still looks the same.

Haven't tested with other password managers. 1Password works fine in Firefox since Firefox doesn't "push" any button.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants