keepassxc hanging with FdoSecrets #8571
Comments
|
AFAICT, this is an artifact of #6943. The problem is that: (A) KeePassXC has a technical limitation that prevents it from searching Secret Service items while the relevant DB is locked. #6943 was implemented to handle A, but it is limited by B. You mentioned that you "started some applications requiring secrets and they timed out because I didn't unlock". The client timeout is because of B. Do you have "Prompt to unlock database before searching" enabled? |
Yes, I do. When I (tried) unlocking, the whole application was blocked. To be honest I'm not sure if I was able to unlock before the hang happened. Does this help? |
It should not be. While you are right with the reason A and B, the unlock prompt on the KPXC side is implemented using an event loop so it won't hang KPXC. It will not reply to the searchItem DBus call, so from the client side of view, it appears that the method call is blocking. But KPXC should never blocks. And if the client application is implemented properly, the blocking DBus call should also not block its own UI. The stack trace confirms above and actually appears to be infinite recursion: it's in While I eyeball the code to find potential triggers for recursion, could you try to reduce the reproduction (e.g. try with an empty database) and be more specific about how this is triggered? (e.g. is this specific one application, or always the same set of applications? ) Also, how did you get the debug symbols? the source mapping is clearly off: the method is in |
|
Also, from the other issue you opened, I assumed you already tested this using the latest snapshot build? |
|
Perhaps we need to block subsequent search requests if we are still processing one. |
|
I cant retest right now, I'll do next week. Regarding the revision: I linked the commit id in the bug report, so yes, its a quite new snapshot revision (plus the extra branch merged). I regularly use the following applications that are triggered on startup and request stored credentials: vscode, element-desktop, and nextcloud. I just built using |
There's #8084. But even without that KPXC shouldn't freeze. |
|
I faced the same behavior using |
|
I also tried a few times, but was unable to reproduce the issue unfortunately :( |
Overview
When using keepassxc with FdoSecrets enabled it became hanging
Steps to Reproduce
I'm not sure. I started the some applications requiring secrets and they timed out because I didnt unlock
Expected Behavior
Not hanging
Actual Behavior
keepass didnt respond anymore
Context
Stacktrace I got.
KeePassXC - 2.7.2 snapshot
Revision: f56fcdd plus
hotfix/focus-crashon topOperating System: Linux
Desktop Env: KDE
Windowing System: X11
The text was updated successfully, but these errors were encountered: