Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistently name folders for testing stubs #56

Closed
TheZ3ro opened this issue Oct 25, 2016 · 3 comments
Closed

Consistently name folders for testing stubs #56

TheZ3ro opened this issue Oct 25, 2016 · 3 comments

Comments

@TheZ3ro
Copy link
Contributor

TheZ3ro commented Oct 25, 2016

Expected Behavior

All the application tests should be in the tests/ folder
Platform-dependent tests should be in test/ folder

Current Behavior

Some tests are not in the tests folder and behave feature-dependent and not platform-dependent
(like X11 Autotype)

@droidmonkey droidmonkey changed the title Organize tests in test/ folder Organize all test cases into the tests folder Oct 30, 2016
@droidmonkey droidmonkey modified the milestone: v2.1.0 Nov 25, 2016
@TheZ3ro
Copy link
Contributor Author

TheZ3ro commented Dec 3, 2016

In reality this is fixed.

The current behavior is fine because the src/autotype/test folder is a Test interface for the Qt PluginLoader (instead of Mac, X11 or Windows interface).

Can we close this? @droidmonkey

@droidmonkey
Copy link
Member

droidmonkey commented Dec 3, 2016

Yes I think we can close this as I will likely do the same thing in the http folder for the http tests (mock of the Chrome/Firefox plugin interface).

Although we might want to rename to "mock" to be clear??

@TheZ3ro
Copy link
Contributor Author

TheZ3ro commented Dec 4, 2016

By me is fine renaming the folder to "mock" or "stub".

@droidmonkey droidmonkey changed the title Organize all test cases into the tests folder Consistently name folders for testing stubs Jan 3, 2017
@phoerious phoerious modified the milestones: v2.1.0, v2.2.0 Jan 14, 2017
@droidmonkey droidmonkey modified the milestones: v2.3.0, v2.2.0 May 7, 2017
@phoerious phoerious modified the milestones: v2.3.0, Future Jan 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants