Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For portable mode artifact, including a keepassxc.ini risks overwriting existing keepassxc.ini #4786

Closed
stdedos opened this issue May 27, 2020 · 3 comments

Comments

@stdedos
Copy link

stdedos commented May 27, 2020

If the average Joe cleanly de-compresses a new portable version on top of an existing one (and assuming that ofc the default "Replace All" is selected), then:

Expected Behavior

Existing configuration is preserved

Actual Behavior

Existing configuration is lost

Proposed Solution

Rename keepassxc.ini to something else, e.g. keepassxc.ini.in

If portable mode is detected by the existence of keepassxc.ini, then this needs to be fixed (e.g. make it depend on both keepassxc.ini and keepassxc.ini.in doing cp keepassxc.ini.in keepassxc.ini if keepassxc.ini does not exist)


Operating System: Windows

@stdedos stdedos added the bug label May 27, 2020
@stdedos
Copy link
Author

stdedos commented May 27, 2020

Related to #4751 (comment)

@stdedos
Copy link
Author

stdedos commented May 27, 2020

Or pick keepassxc.orig.ini if no templating is done: highlighting is preserved in extension-based highlighters

@droidmonkey
Copy link
Member

This is covered under the discussion in #4751 which will be implemented in 2.6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants