Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clearer stackedWidget index using enum #442

Merged
merged 1 commit into from
Mar 29, 2017
Merged

Clearer stackedWidget index using enum #442

merged 1 commit into from
Mar 29, 2017

Conversation

TheZ3ro
Copy link
Contributor

@TheZ3ro TheZ3ro commented Mar 29, 2017

Description

Instead of using hardcoded index, use clearer enum label

Motivation and context

Requested by @droidmonkey in #437 (comment)

How has this been tested?

Manually + Test + Travis

Types of changes

  • ✅ Bug fix (non-breaking change which fixes an issue)

Checklist:

  • ✅ I have read the CONTRIBUTING document. [REQUIRED]
  • ✅ My code follows the code style of this project. [REQUIRED]
  • ✅ All new and existing tests passed. [REQUIRED]
  • ✅ I have compiled and verified my code with -DWITH_ASAN=ON. [REQUIRED]

droidmonkey
droidmonkey approved these changes Mar 29, 2017
View reviewed changes
Copy link
Member

@droidmonkey droidmonkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HOT! That is much more readable

@droidmonkey droidmonkey merged commit f183260 into develop Mar 29, 2017
@droidmonkey droidmonkey deleted the fix/revampStackedWidgetIndex branch March 29, 2017 21:27
@phoerious phoerious added this to the v2.2.0 milestone Apr 9, 2017
supershoop pushed a commit to supershoop/keepassxc that referenced this pull request Oct 5, 2022
@debfx
Save to canonical file path so we don't overwrite symlinks.
e9c8363 
When saving a database we previously replaced symlinks with a regular file.

Closes keepassxreboot#442
@phoerious phoerious added pr: new feature Pull request that adds a new feature and removed new feature labels Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@droidmonkey droidmonkey droidmonkey approved these changes

@louib louib louib approved these changes

Assignees
No one assigned
Labels
pr: new feature Pull request that adds a new feature
Projects
None yet
Milestone
v2.2.0
Development

Successfully merging this pull request may close these issues.
4 participants
@TheZ3ro @droidmonkey @louib @phoerious