Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix entry sorting by title #1993

Merged
merged 1 commit into from
Jun 15, 2018

Conversation

varjolintu
Copy link
Member

Fixes Sort matching credentials by title.

Description

Previously sorting by title didn't sort usernames after the title sort, and the order was not reverse but mixed. The sort provided the following results:

c_username (title1)
z_username (title1)
a_username (title1)
z_username (title2)
c_username (title2)
a_username (title2)
...

After the fix:

a_username (title1)
c_username (title1)
z_username (title1)
a_username (title2)
c_username (title2)
z_username (title2)

If the titles are identical another compare is made based on the username.

How has this been tested?

Manually.

Types of changes

  • ✅ Bug fix (non-breaking change which fixes an issue)

Checklist:

  • ✅ I have read the CONTRIBUTING document. [REQUIRED]
  • ✅ My code follows the code style of this project. [REQUIRED]
  • ✅ All new and existing tests passed. [REQUIRED]
  • ✅ I have compiled and verified my code with -DWITH_ASAN=ON. [REQUIRED]

@varjolintu
Copy link
Member Author

I would also add this PR one more thing: remove the URL compare to the entry title. That doesn't make any sense. If I have an entry to a totally different site, but for some reason the entry title contains that site, the credentials are returned for that entry too.

@droidmonkey droidmonkey merged commit e825b55 into keepassxreboot:release/2.3.4 Jun 15, 2018
@varjolintu varjolintu deleted the title_sort_fix branch June 16, 2018 05:15
droidmonkey added a commit that referenced this pull request Aug 22, 2018
- Show all URL schemes in entry view [#1768]
- Disable merge when database is locked [#1975]
- Fix intermittent crashes with favorite icon downloads [#1980]
- Provide potential crash warning to Qt 5.5.x users [#2211]
- Disable apply button when creating new entry/group to prevent data loss [#2204]
- Allow for 12 hour timeout to lock idle database [#2173]
- Multiple SSH Agent fixes [#1981, #2117]
- Multiple Browser Integration enhancements [#1993, #2003, #2055, #2116, #2159, #2174, #2185]
- Fix browser proxy application not closing properly [#2142]
- Add real names and Patreon supporters to about dialog [#2214]
- Add settings button to toolbar, Donate button, and Report a Bug button to help menu [#2214]
- Enhancements to release-tool to appsign intermediate build products [#2101]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants