Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auto-open code needs to be in separate function #1259

Closed
droidmonkey opened this issue Dec 8, 2017 · 4 comments
Closed

Auto-open code needs to be in separate function #1259

droidmonkey opened this issue Dec 8, 2017 · 4 comments
Assignees
@droidmonkey
Labels
accessibility user interface
Milestone
v2.4.0

Comments

@droidmonkey
Copy link
Member

droidmonkey commented Dec 8, 2017 •
edited
Loading

The auto-open code that was approved in PR #1053 was incorrectly stuffed into a totally unrelated function. This code needs to be placed in it's own function and called appropriately.

https://github.com/keepassxreboot/keepassxc/blob/develop/src/gui/DatabaseTabWidget.cpp#L628
@droidmonkey droidmonkey added this to the v2.3.0 milestone Dec 8, 2017
@droidmonkey droidmonkey self-assigned this Dec 8, 2017
@droidmonkey droidmonkey changed the title Autoopen Code needs to be in separate function Auto-open code needs to be in separate function Dec 8, 2017
@phoerious phoerious modified the milestones: v2.3.0, v2.4.0 Jan 28, 2018
@TheZ3ro
Copy link
Contributor

TheZ3ro commented Feb 27, 2018 •
edited
Loading

Also, add to auto-open urls that start with kdbx://, right now only file:// is supported but KeePass plugin also use the first one

@TheZ3ro
Copy link
Contributor

TheZ3ro commented Feb 27, 2018

Related #1420. The autoopen function should run in background and not open the Main Window

@TheZ3ro TheZ3ro mentioned this issue Feb 27, 2018
Closed
@pquerner pquerner mentioned this issue Jun 29, 2018
Closed
@droidmonkey
Copy link
Member Author

The setup and configuration of auto open should be added as a GUI element to the Database Settings.

@droidmonkey droidmonkey mentioned this issue Oct 4, 2018
Closed
@droidmonkey
Copy link
Member Author

This was fixed with #2504

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@droidmonkey droidmonkey

Labels
accessibility user interface
Projects
None yet
Milestone
v2.4.0
Development

No branches or pull requests
3 participants
@TheZ3ro @phoerious @droidmonkey