Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Within Brave on MacOS, I can't have KeePassXC Extension connect to KeePassXC #541

Closed
pingouiny opened this issue May 12, 2019 · 18 comments
Closed

Comments

@pingouiny
Copy link

Expected Behavior

Would like to connect the KeePassXC Browser extension from within Brave, to the KeePassXC DB

Current Behavior

When pressing on the "Connect" button, nothing happen. Chromium & Brave browser integration are enabled in KeePassXC.

Possible Solution

Steps to Reproduce (for bugs)

  1. Keepass Icon > Settings > Connected Database > press the "Connect"button

Debug info

KeePassXC - Version 2.4.1 Revision: 7bafe65
KeePassXC-Browser - Version 1.4.3
Operating system - macOS Mojave (10.14)
Browser - Brave Version 0.63.55 Chromium: 74.0.3729.131 (Official Build) (64-bit)

@varjolintu varjolintu added the bug label May 12, 2019
@droidmonkey
Copy link
Member

Confirmed it does not work. Brave + macOS

@varjolintu
Copy link
Member

I've never succeed to get Brave working with macOS, even if the original PR that added support for it was approved and merged.

@droidmonkey
Copy link
Member

I wonder if they have sandboxed Brave and did not open the native messaging capability

@derzahla
Copy link

derzahla commented Jun 29, 2019

Same here. I use the latest Brave Dev but also tried Brave stable. Here's some debug info I captured:

Connecting to native messaging host org.keepassxc.keepassxc_browser keepass.js:969 Failed to connect: Specified native messaging host not found. keepass.js:1192 Objectmessage: (...)get message: ƒ ()arguments: (...)caller: (...)length: 0name: ""__proto__: ƒ ()apply: ƒ apply()arguments: (...)bind: ƒ bind()call: ƒ call()caller: (...)constructor: ƒ Function()length: 0name: ""toString: ƒ toString()Symbol(Symbol.hasInstance): ƒ [Symbol.hasInstance]()get arguments: ƒ ()set arguments: ƒ ()get caller: ƒ ()set caller: ƒ ()__proto__: Object[[FunctionLocation]]: <unknown>[[Scopes]]: Scopes[0]No properties[[Scopes]]: Scopes[0]No properties__proto__: Object browser-polyfill.min.js:1 Returning a Promise is the preferred way to send a reply from an onMessage/onMessageExternal listener, as the sendResponse will be removed from the specs (See https://developer.mozilla.org/docs/Mozilla/Add-ons/WebExtensions/API/runtime/onMessage) Error at B (chrome-extension://oboonakemofpalcgghocfoadofidjkkk/browser-polyfill.min.js:1:8152) at chrome-extension://oboonakemofpalcgghocfoadofidjkkk/background/event.js:108:9 B @ browser-polyfill.min.js:1 keepass.js:1078 Error 5: Cannot connect to KeePassXC. Check that browser integration is enabled in KeePassXC settings. keepass.js:993 Connecting to native messaging host org.keepassxc.keepassxc_browser keepass.js:969 Failed to connect: Specified native messaging host not found. keepass.js:1192 {}message: (...)get message: ƒ ()arguments: (...)caller: (...)length: 0name: ""__proto__: ƒ ()apply: ƒ apply()arguments: (...)bind: ƒ bind()call: ƒ call()caller: (...)constructor: ƒ Function()length: 0name: ""toString: ƒ toString()Symbol(Symbol.hasInstance): ƒ [Symbol.hasInstance]()get arguments: ƒ ()set arguments: ƒ ()get caller: ƒ ()set caller: ƒ ()__proto__: Object[[FunctionLocation]]: <unknown>[[Scopes]]: Scopes[0][[Scopes]]: Scopes[0]No properties__proto__: constructor: ƒ ()__proto__: Object keepass.js:1078 Error 9: Key exchange was not successful.

@varjolintu
Copy link
Member

That debug doesn't provide any new info. The native messaging host (meaning the proxy) cannot be found by the browser.

@JPfeifer
Copy link

JPfeifer commented Aug 8, 2019

Removing
~/Library/Application\ Support/BraveSoftware/Brave-Browser/NativeMessagingHosts/org.keepassxc.keepassxc_browser.json
solved the issue for me.

KeePassXC - Version 2.4.3 Revision: 5d6ef0c
KeePassXC-Browser - Version 1.4.7
Operating system - macOS Mojave (10.14)
Browser - Brave Version 0.67.124 Chromium: 76.0.3809.100 (Official Build) (64-bit)

@ghost
Copy link

ghost commented Aug 23, 2019

I have a similar problem with Brave 0.68.131 on Ubuntu Mate 18.04, just installed KeePassXC 2.3.1, which seems to be the latest version using apt install. When clicking the icon in the browser I receive the message "Cannot connect to KeePassXC. Check that browser integration is enabled in KeePassXC settings.", than after clicking reload I get "Key exchange was not successful.". I followed instructions in the documents on the KeePassXC website.

@varjolintu
Copy link
Member

@Carlossuss Use the official PPA to install the latest version.

@ghost
Copy link

ghost commented Aug 24, 2019

@Carlossuss Use the official PPA to install the latest version.

Thank you, that worked.

@HarukaMa
Copy link

(Copy-paste from brave/brave-browser#5074 (comment))

According to browserpass/browserpass-native#43 (comment), this is caused by Brave browser still looking for native messaging hosts definitions from ~/Library/Application Support/Google/Chrome/NativeMessagingHosts, not ~/Library/Application Support/BraveSoftware/Brave-Browser{,-Dev,...}/NativeMessagingHosts.

I think this is a completely unexpected behavior and a bug of Brave browser.

@Birkenstab
Copy link

Yeah, I noticed that too. I had to enable Chrome integration in KepassXC instead of Brave integration

@varjolintu
Copy link
Member

If this is really a Brave bug, then this issue is closed.

@droidmonkey
Copy link
Member

Nice fix to just choose chrome though!

@lugipfupf
Copy link

I know, this is old & closed. But almost a year later, I ran into the same problem. The simple solution provided by @Birkenstab did the job. Thank you.

@yarongon
Copy link

Again, another year passed and I have the same problem. How do I enable Chrome integration? I went over all the configurations and did not see such an option.

@varjolintu
Copy link
Member

@yarongon Hmm? You are writing about Chrome issue to Brave thread? Could you elaborate your problem a little bit more? KeePassXC settings -> Browser Integration has all the browser options available.

@yarongon
Copy link

@varjolintu sorry, I did not realize I had to enable it from the KeePassXC app. Its working now. Thanks!

@willunikbass
Copy link

I confirm that @Birkenstab solution works perfectly and I could connect to my database.
In browser intégration Keepass app settings, just choose Google Chrome (and Chromium may be) instead of Brave.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

10 participants