Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Library does networks requests on the main thread and errors aren't handled #125

Open
tadas-subonis opened this issue Apr 3, 2017 · 3 comments

Comments

@tadas-subonis
Copy link

If the call .add_event() fails due to the connectivity issues to your servers or some other reason, it will throw an exception that will kill the thread that called it.

This is something you want to avoid for a tracking library - I want my services to still work even if your servers are down or unreachable to some other reason.

Now, I have to rely on using a ThreadPoolExecutor with try ... except that catches all exceptions and does logging.

@masojus
Copy link
Contributor

masojus commented Apr 18, 2017

It sounds like half of the problem is Issue #9 and the other half is due to holes in error handling. Correct? So initially the latter is going to be easier to correct as a mitigation, but Issue #9 will still need to be addressed.

@tadas-subonis
Copy link
Author

@masojus Yes. To me, The core issue is the calls blocking main thread.

@masojus
Copy link
Contributor

masojus commented Apr 18, 2017

@tadas-subonis Ok, good to know. Issue #9 is pretty stale, but it might merit a bump in priority. Thank you for the input.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants