Misleading error message when credentials are invalid

[astrojuanlu]

Description

Context

Steps to Reproduce

Checklist

• Have you read the "Requirements" section already?
• Have you make sure you are running the extension with the correct virtual environment? Cmd + P and Python: Select Interpeter

Expected Result

Actual Result

-- If you received an error, place it here.

-- Separate them if you have more than one.

Your Environment

• Kedro version used (pip show kedro or kedro -V):
• Kedro VSCode version used
• Python version used (python -V):
• Operating system and version:

[noklam]

                        diagnostic = Diagnostic(
                            range=Range(
                                start=Position(line=line_number, character=start_char),
                                end=Position(line=line_number, character=end_char),
                            ),
                            message=f"Dataset '{dataset_name}' has an invalid type '{dataset_type}'. {dataset_exception}",
                            severity=DiagnosticSeverity.Error,
                            source="Kedro LSP",
                        )
                        diagnostics.append(diagnostic)

This seems to be a message we added ourselves. What if we just brings the raw exception?

[astrojuanlu]

I guess you mean

vscode-kedro/bundled/tool/lsp_server.py

Lines 621 to 639 in c4cde3d

	try:
	DataCatalog.from_config({dataset_name: clean_dataset_config})
	except Exception as dataset_exception:
	# Add diagnostic for invalid dataset
	line_info = find_line_number_and_character(content, dataset_name, "type")
	if line_info:
	line_number, start_char = line_info
	dataset_type = dataset_config.get("type", "Unknown")
	end_char = start_char + len(f"type: {dataset_type}")
	diagnostic = Diagnostic(
	range=Range(
	start=Position(line=line_number, character=start_char),
	end=Position(line=line_number, character=end_char),
	),
	message=f"Dataset '{dataset_name}' has an invalid type '{dataset_type}'. {dataset_exception}",
	severity=DiagnosticSeverity.Error,
	source="Kedro LSP",
	)
	diagnostics.append(diagnostic)

I agree, just not making assumptions about the underlying exception should be good