Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make it possible to use Kedro after uninstalling Rich. #3838
Make it possible to use Kedro after uninstalling Rich. #3838
Changes from 6 commits
3f39cd3
80f0ff2
8c07db1
6c66689
d883b5d
e35cdaa
bfbb1f1
2038792
5b85711
b75327d
de86e8d
658d0c1
609a0c2
99bd891
a15bdcd
e80d514
f802384
b5aed65
5061229
7c731f3
c63c068
a29220c
f43c72c
8389023
1ea51e8
6b98284
3663bdf
115d339
16e05b8
269ec98
5f3640b
235a5bf
c1f6cbf
210b0ed
98f8e4d
191bba7
b44fb5e
c4c8aa7
d76124f
9dbaf94
0c63233
f3c65fa
1be4b05
4775fe4
671917d
a8fea7a
eb3b151
0f0214f
192d349
28534ad
02d8919
2074054
8c15acb
6cf7d4d
61f44ce
6a41b4d
4f57399
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the basic idea that users who don't install rich should default to this? So for users who already have rich installed and no longer want it they need to
pip uninstall rich
? If that is the case we should document the steps they need to take.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@noklam do you have any thoughts on this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My thought on this it shouldn't touch the log handler.
If the custom logger has Rich handler, it should raise error when it is not installed. To get rid of this the solution is just remove rich from the handler.
The thing that user cannot change now is all the traceback error / CLI that ties with rich. Essentially one cannot run Kedro without rich. @astrojuanlu
I am surprised the _ProjectLogging isn't changed here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SajidAlamQB yes, the way this is set up at the moment, if the user does not want rich to be used, it would need to be uninstalled.