Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Streamline debugging documentation #3608

Merged
merged 33 commits into from
Feb 12, 2024
Merged

Conversation

AhdraMeraliQB
Copy link
Contributor

@AhdraMeraliQB AhdraMeraliQB commented Feb 9, 2024

Description

Addresses #2672. Blocks #2011.

As discussed with Jo - this is the new proposed structure:

  • Tutorial and basic Kedro usage

    • Use a Notebook...
      • How to explore...
        • [Line magics]
        • ADD: %load_node line magic - in #2011
      • CREATE: Debugging a Kedro project within a notebook - in this PR
        • ADD: Debugging with %load_node #2011
        • MOVE: Debugging with %debug... - in this PR
      • Useful to know
        • Managed services
        • ...
  • Advanced Usage

    • Hooks
      • Common use cases
        • ADD: Using hooks for post-mortem debugging - in this PR
    • Development
      • Set up {IDE}
        • Debugging in {IDE}
    • REMOVE: Debugging - in this PR

It was flagged that the debugging page shouldn't be wholly removed, instead now it serves as a source for links on the specific debugging workflows

Development notes

Developer Certificate of Origin

We need all contributions to comply with the Developer Certificate of Origin (DCO). All commits must be signed off by including a Signed-off-by line in the commit message. See our wiki for guidance.

If your PR is blocked due to unsigned commits, then you must follow the instructions under "Rebase the branch" on the GitHub Checks page for your PR. This will retroactively add the sign-off to all unsigned commits and allow the DCO check to pass.

Checklist

  • Read the contributing guidelines
  • Signed off each commit with a Developer Certificate of Origin (DCO)
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added a description of this change in the RELEASE.md file
  • Added tests to cover my changes
  • Checked if this change will affect Kedro-Viz, and if so, communicated that with the Viz team

lrcouto and others added 26 commits January 31, 2024 01:21
Signed-off-by: lrcouto <[email protected]>
Signed-off-by: Ahdra Merali <[email protected]>
Signed-off-by: Ahdra Merali <[email protected]>
Signed-off-by: lrcouto <[email protected]>
Signed-off-by: Ahdra Merali <[email protected]>
@AhdraMeraliQB AhdraMeraliQB changed the title Docs/streamline debugging docs Streamline debugging documentation Feb 9, 2024
Signed-off-by: Ahdra Merali <[email protected]>
@AhdraMeraliQB AhdraMeraliQB requested review from noklam and lrcouto and removed request for yetudada February 9, 2024 13:39
@@ -201,7 +201,7 @@ HOOKS = (AzureSecretsHook(),)
Note: `DefaultAzureCredential()` is Azure's recommended approach to authorise access to data in your storage accounts. For more information, consult the [documentation about how to authenticate to Azure and authorize access to blob data](https://learn.microsoft.com/en-us/azure/storage/blobs/storage-quickstart-blobs-python).
```

## Use a Hook to read `metadata` from `DataCatalog`
## Use Hooks to read `metadata` from `DataCatalog`
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed tense for consistency

@@ -214,3 +214,77 @@ class MetadataHook:
for dataset_name, dataset in catalog.datasets.__dict__.items():
print(f"{dataset_name} metadata: \n {str(dataset.metadata)}")
```

## Use Hooks to debug your pipeline
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This section was ported over from debugging.md


### Debugging with %debug and %pdb
## Debugging a Kedro project within a notebook
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This subsection is subject to further changes in #2011

Copy link
Contributor

@stichbury stichbury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few minor comments but looks fantastic, thanks @AhdraMeraliQB !

AhdraMeraliQB and others added 5 commits February 9, 2024 14:35
Co-authored-by: Jo Stichbury <[email protected]>
Signed-off-by: Ahdra Merali <[email protected]>
Signed-off-by: Ahdra Merali <[email protected]>
Signed-off-by: Ahdra Merali <[email protected]>
Signed-off-by: Ahdra Merali <[email protected]>
Copy link
Contributor

@lrcouto lrcouto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@AhdraMeraliQB AhdraMeraliQB merged commit 80ad182 into main Feb 12, 2024
9 checks passed
@AhdraMeraliQB AhdraMeraliQB deleted the docs/streamline-debugging-docs branch February 12, 2024 10:06
@AhdraMeraliQB AhdraMeraliQB linked an issue Feb 12, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revisit Debugging documentation in Kedro
3 participants