%load_node experiments #3568
Merged
%load_node experiments #3568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
AhdraMeraliQB
force-pushed
the
ahdra/load-node-experiments
branch
from
306c98d to
45ec09c
Compare
added 15 commits
February 1, 2024 08:26
Signed-off-by: Ahdra Merali <[email protected]>
Signed-off-by: Ahdra Merali <[email protected]>
Signed-off-by: Ahdra Merali <[email protected]>
Signed-off-by: Ahdra Merali <[email protected]>
Signed-off-by: Ahdra Merali <[email protected]>
Signed-off-by: Ahdra Merali <[email protected]>
This reverts commit 63ee194. Signed-off-by: Ahdra Merali <[email protected]>
Signed-off-by: Ahdra Merali <[email protected]>
Signed-off-by: Ahdra Merali <[email protected]>
Signed-off-by: Ahdra Merali <[email protected]>
Signed-off-by: Ahdra Merali <[email protected]>
Signed-off-by: Ahdra Merali <[email protected]>
This reverts commit ad63afc. Signed-off-by: Ahdra Merali <[email protected]>
This reverts commit 04c022e. Signed-off-by: Ahdra Merali <[email protected]>
Signed-off-by: Ahdra Merali <[email protected]>
AhdraMeraliQB
force-pushed
the
ahdra/load-node-experiments
branch
from
5b9ddb1 to
4581373
Compare
AhdraMeraliQB
merged commit 5d3b898
into
2009-create-line-magic-to-debug-a-node-in-notebook-workflow
2 checks passed
AhdraMeraliQB
added a commit
that referenced
this pull request
Feb 1, 2024
* Simplify mocking Signed-off-by: Ahdra Merali <[email protected]> * Check node func names Signed-off-by: Ahdra Merali <[email protected]> * Naive fix for return statements Signed-off-by: Ahdra Merali <[email protected]> * Handle nested case Signed-off-by: Ahdra Merali <[email protected]> * Change pipelines fixture type Signed-off-by: Ahdra Merali <[email protected]> * Remove unnecessary TODO Signed-off-by: Ahdra Merali <[email protected]> * Revert "Check node func names" This reverts commit 63ee194. Signed-off-by: Ahdra Merali <[email protected]> * Replace commented return statements with a display() statement Signed-off-by: Ahdra Merali <[email protected]> * Add warning about node name when node not found Signed-off-by: Ahdra Merali <[email protected]> * Add line about debugging inputs in catalog Signed-off-by: Ahdra Merali <[email protected]> * Lint Signed-off-by: Ahdra Merali <[email protected]> * Change wording Signed-off-by: Ahdra Merali <[email protected]> * Revert "Replace commented return statements with a display() statement" This reverts commit ad63afc. Signed-off-by: Ahdra Merali <[email protected]> * Revert "Naive fix for return statements" This reverts commit 04c022e. Signed-off-by: Ahdra Merali <[email protected]> * Update tests Signed-off-by: Ahdra Merali <[email protected]> --------- Signed-off-by: Ahdra Merali <[email protected]>
noklam
added a commit
that referenced
this pull request
Feb 2, 2024
* update notes Signed-off-by: Nok Lam Chan <[email protected]> * add some basic structure for the debugging magic Signed-off-by: Nok Lam Chan <[email protected]> * add demo code Signed-off-by: Nok Lam Chan <[email protected]> * lint Signed-off-by: Nok Lam Chan <[email protected]> * implement the _find_node and _prepare_node_inputs function Signed-off-by: Nok Lam Chan <[email protected]> * implement _prepare_imports Signed-off-by: Nok Lam Chan <[email protected]> * clean up the import function to use the real function Signed-off-by: Nok Lam Chan <[email protected]> * separate the cells into different part Signed-off-by: Nok Lam Chan <[email protected]> * update dependencies Signed-off-by: Nok Lam Chan <[email protected]> * add test structure Signed-off-by: Nok Lam Chan <[email protected]> * Lint Signed-off-by: Ahdra Merali <[email protected]> * Add some tests and placeholders Signed-off-by: Ahdra Merali <[email protected]> * Add more tests Signed-off-by: Ahdra Merali <[email protected]> * Even more tests Signed-off-by: Ahdra Merali <[email protected]> * And more tests Signed-off-by: Ahdra Merali <[email protected]> * Remove placeholders Signed-off-by: Ahdra Merali <[email protected]> * test remove condition Signed-off-by: Ahdra Merali <[email protected]> * add more dcostring Signed-off-by: Nok Lam Chan <[email protected]> * add logs Signed-off-by: Nok Lam Chan <[email protected]> * refactor the test and fix imports Signed-off-by: Nok Lam Chan <[email protected]> * more tests fixed Signed-off-by: Nok Lam Chan <[email protected]> * refacto tests with list of string with """ Signed-off-by: Nok Lam Chan <[email protected]> * Fix node Signed-off-by: Nok Lam Chan <[email protected]> * replace test with triple quotes string Signed-off-by: Nok Lam Chan <[email protected]> * rename function to the _prepare pattern Signed-off-by: Nok Lam Chan <[email protected]> * fix more test Signed-off-by: Nok Lam Chan <[email protected]> * skip tests Signed-off-by: Nok Lam Chan <[email protected]> * Lint Signed-off-by: Ahdra Merali <[email protected]> * Add ipylab to test requirements Signed-off-by: Ahdra Merali <[email protected]> * Fix missing syntax Signed-off-by: Ahdra Merali <[email protected]> * Apply suggestion from code review Signed-off-by: Ahdra Merali <[email protected]> * Remove redundant TODOs Signed-off-by: Ahdra Merali <[email protected]> * Fix handling node with lambda function Signed-off-by: Ahdra Merali <[email protected]> * Try pin pluggy Signed-off-by: Ahdra Merali <[email protected]> * refactor the find_node method with pipeline as argument and tests Signed-off-by: Nok Lam Chan <[email protected]> * Update kedro/ipython/__init__.py Co-authored-by: Ankita Katiyar <[email protected]> Signed-off-by: Nok Lam Chan <[email protected]> * Re-import mocked object Signed-off-by: Ahdra Merali <[email protected]> * Remove try-catch Signed-off-by: Ahdra Merali <[email protected]> * Rename overwritten varaible Signed-off-by: Ahdra Merali <[email protected]> * Add warnings and simplify tests (#3568) * Simplify mocking Signed-off-by: Ahdra Merali <[email protected]> * Check node func names Signed-off-by: Ahdra Merali <[email protected]> * Naive fix for return statements Signed-off-by: Ahdra Merali <[email protected]> * Handle nested case Signed-off-by: Ahdra Merali <[email protected]> * Change pipelines fixture type Signed-off-by: Ahdra Merali <[email protected]> * Remove unnecessary TODO Signed-off-by: Ahdra Merali <[email protected]> * Revert "Check node func names" This reverts commit 63ee194. Signed-off-by: Ahdra Merali <[email protected]> * Replace commented return statements with a display() statement Signed-off-by: Ahdra Merali <[email protected]> * Add warning about node name when node not found Signed-off-by: Ahdra Merali <[email protected]> * Add line about debugging inputs in catalog Signed-off-by: Ahdra Merali <[email protected]> * Lint Signed-off-by: Ahdra Merali <[email protected]> * Change wording Signed-off-by: Ahdra Merali <[email protected]> * Revert "Replace commented return statements with a display() statement" This reverts commit ad63afc. Signed-off-by: Ahdra Merali <[email protected]> * Revert "Naive fix for return statements" This reverts commit 04c022e. Signed-off-by: Ahdra Merali <[email protected]> * Update tests Signed-off-by: Ahdra Merali <[email protected]> --------- Signed-off-by: Ahdra Merali <[email protected]> * Add universal warnings Signed-off-by: Nok Lam Chan <[email protected]> * Change to copy full function definition instead of just function body Signed-off-by: Nok Lam Chan <[email protected]> * 1 down, 4 more tests to fix Signed-off-by: Nok Lam Chan <[email protected]> * fix extra empty space Signed-off-by: Nok Lam Chan <[email protected]> * fix tests Signed-off-by: Nok Lam Chan <[email protected]> * Update release notes and some typos Signed-off-by: Nok Lam Chan <[email protected]> --------- Signed-off-by: Nok Lam Chan <[email protected]> Signed-off-by: Ahdra Merali <[email protected]> Co-authored-by: Ahdra Merali <[email protected]> Co-authored-by: Ahdra Merali <[email protected]> Co-authored-by: Ankita Katiyar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds: