-
Notifications
You must be signed in to change notification settings - Fork 926
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DataCatalog]: Disable catalog.load()
logging
#3918
Comments
Relaying internal discussion:
|
I’m not sure we should have a custom approach for dealing with logging for dataset loading compared to other log messages. |
The amount of logging information during the I also agree that adding a custom flag just for one method - Based on the above we can consider the following:
|
kedro/kedro/io/data_catalog.py Lines 201 to 203 in 413dbca
This is a pattern I've never seen. And yet, can't the user do logging.getLogger("kedro.io.data_catalog").setLevel(logging.WARNING) ? (Haven't tested this, unsure if it works) |
Yes, that works and doesn't affect the top-level loggers! So I believe that should be the solution and no changes are required as all of them lead to the same amount of effort from the user side. Closing the issue. |
So I still think we should make this easier for the user:
|
Good point, I will extend the section on how to customise logging then. But I would not change the default |
Completed in #3968 |
Description
catalog.load()
produces extensive logging information when loading multiple datasets in the same notebook cell. These logger messages annoy users and cannot be disabled with the current implementation.Context
"It’s very convenient to load my dataset when debugging locally. The only annoying thing is the multiple
logger.info
messages I get when I load multiple datasets in the same notebook cell."Possible Implementation
catalog.load()
to disable logging prints for cleaner outputs.catalog.load()
can be reduced.The text was updated successfully, but these errors were encountered: