Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default to raise_errors=True in find_pipelines #3886

Open
3 tasks
deepyaman opened this issue May 22, 2024 · 1 comment
Open
3 tasks

Default to raise_errors=True in find_pipelines #3886

deepyaman opened this issue May 22, 2024 · 1 comment

Comments

@deepyaman
Copy link
Member

deepyaman commented May 22, 2024

Thanks, a bit late to the discussion. I agree we should not change the behavior in a micro release.

In principle I like a default=True, but with concern about discoverability and the ergonomics of this. I imagine this is like a switch that you may need to turn on & off from time to time, going into pipeline_registry.py to do so feel inconsistent with other CLI options etc.

Originally posted by @noklam in #3823 (review)

TODO:

  • Default to raise_errors=True in next major release
  • Warn that the default behavior will change? Not sure whether this is worth it—the warning would be annoying on each run
  • Expose a config option for raise_errors?
@bpmeek
Copy link

bpmeek commented May 31, 2024

Something I would like to see is changing the default entry in pipeline_registry.py to find_pipelines(raise_errors=True) (or False whichever is decided upon), I didn't know until yesterday that this was even a functionality of find_pipelines().

Which may even open up a broader question of "Should Kedro populate default options in the boilerplate to let users know its there?"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants