Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test fails after following contribution guide and install dependencies in a fresh environment. #3702

Closed
noklam opened this issue Mar 13, 2024 · 0 comments · Fixed by #3705
Closed

Comments

@noklam
Copy link
Contributor

noklam commented Mar 13, 2024

Description

image

Test fails after fresh installation

Context

This impact the contributing process as it adds burden on the contributor side to fix something that they didn't caused or confusing anyway.

Few observations:

  • I notice test are mostly marked as @SKIP_ON_WINDOWS, it's possible we should skip it on Mac too (unsure why yet)
  • Tests pass on CI
  • Suspect unknown test dependencies

Steps to Reproduce

  1. Create new environment
  2. make install-test-requirements and make test

Expected Result

Test should pass

Actual Result

-- If you received an error, place it here.
-- Separate them if you have more than one.

Your Environment

  • Kedro version used (pip show kedro or kedro -V): 0.19.3 (main)
  • Python version used (python -V): 3.10
  • Operating system and version: MacOS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant