Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename data_sets argument and _data_sets attribute of DataCatalog #3041

Closed
3 tasks
deepyaman opened this issue Sep 18, 2023 · 8 comments · Fixed by #3115
Closed
3 tasks

Rename data_sets argument and _data_sets attribute of DataCatalog #3041

deepyaman opened this issue Sep 18, 2023 · 8 comments · Fixed by #3115
Labels
good first issue Good first issues for beginners

Comments

@deepyaman
Copy link
Member

deepyaman commented Sep 18, 2023

Description

In the DataCatalog rename the data_sets argument to datasets and the _data_sets attribute to _datasets.

To do

  • Should we first deprecate the old one naming? -> Discussed in grooming, deprecation warnings seems like a lot of effort for something that's probably not used by a lot of people. We will mention this very clearly in the migration notes. The _data_sets attribute is mentioned in docs: https://docs.kedro.org/en/stable/data/how_to_create_a_custom_dataset.html#thread-safety
  • Also renamedef data_sets() in Pipeline.
  • and rename all other usages of data_sets in the codebase. E.g. variable and argument names + docs.
@astrojuanlu
Copy link
Member

@noklam I recall you made a comment somewhere about dataset access from the catalog, but I can't locate it

@noklam
Copy link
Contributor

noklam commented Sep 25, 2023

@MinuraPunchihewa
Copy link
Contributor

Hello Kedro Team,
I would like to start contributing to the project and I thought this might be a good place to start. Can I take this up or if you have any other suggestions for a new contributor, I would love to hear it.

@astrojuanlu
Copy link
Member

Hey @MinuraPunchihewa , please go ahead! 🚀 Make sure to read our CONTRIBUTING.md and if you need any help, let us know, here or in https://slack.kedro.org

@MinuraPunchihewa
Copy link
Contributor

Thanks, @astrojuanlu!

@astrojuanlu
Copy link
Member

Should this change happen in main or develop?

@merelcht
Copy link
Member

merelcht commented Oct 5, 2023

Should this change happen in main or develop?

develop because it's a breaking change.

@merelcht merelcht linked a pull request Oct 5, 2023 that will close this issue
7 tasks
@merelcht merelcht moved this from To Do to In Review in Kedro Framework Oct 5, 2023
@astrojuanlu astrojuanlu added the good first issue Good first issues for beginners label Oct 6, 2023
@merelcht
Copy link
Member

merelcht commented Oct 9, 2023

Completed in #3115

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good first issues for beginners
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants