Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove kedro run flags --node, --tag, and --load-version #2245

Closed
AhdraMeraliQB opened this issue Jan 23, 2023 · 3 comments · Fixed by #3279
Closed

Remove kedro run flags --node, --tag, and --load-version #2245

AhdraMeraliQB opened this issue Jan 23, 2023 · 3 comments · Fixed by #3279
Assignees
Labels
Component: CLI Issue/PR that addresses the CLI for Kedro

Comments

@AhdraMeraliQB
Copy link
Contributor

Description

IMPORTANT: This is a breaking change and should go into develop. This should only be implemented after #2243 and #2244.

Once we have implemented the replacement flags, these singular flags should be removed. In this change, ensure the short-form flags -n, -t and -lv are modified to alias the plural form flags --nodes, --tags, and --load-versions instead.

@AhdraMeraliQB
Copy link
Contributor Author

Migrating over some comments from #2244:

  • Currently --node results in the parameter node_names and --nodes in nodes_names. When --node is removed make sure to rename the respective parameter to node_names.
  • Once the old flags are deleted _get_vaules_as_tuple should be able to be deleted as well in favour of using _split_string
  • _reformat_load_version will no longer need to be separate from _split_load_versions and can be combined into one function under _split_load_versions
  • Try to have as much argument wrangling/formatting as possibke handled in the callback functions instead of the call to session.run

@AhdraMeraliQB
Copy link
Contributor Author

Don't forget to remove instances of the singular flags from the docs. These pages are documented in #2246.

@merelcht merelcht moved this to To Do in Kedro Framework Oct 30, 2023
@lrcouto lrcouto moved this from To Do to In Progress in Kedro Framework Nov 3, 2023
@lrcouto lrcouto linked a pull request Nov 9, 2023 that will close this issue
7 tasks
@lrcouto lrcouto moved this from In Progress to In Review in Kedro Framework Nov 9, 2023
@lrcouto lrcouto moved this from In Review to Done in Kedro Framework Nov 9, 2023
@AhdraMeraliQB
Copy link
Contributor Author

Addressed in #3279

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: CLI Issue/PR that addresses the CLI for Kedro
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants