Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove kedro.extras.datasets from Kedro #2126

Closed
Tracked by #1457
merelcht opened this issue Dec 14, 2022 · 3 comments
Closed
Tracked by #1457

Remove kedro.extras.datasets from Kedro #2126

merelcht opened this issue Dec 14, 2022 · 3 comments
Assignees
@noklam
Milestone
Package kedro.ext...

Comments

@merelcht
Copy link
Member

merelcht commented Dec 14, 2022 •
edited by noklam
Loading

Description

  • Remove kedro.extras.datasets (and kedro.extras too)
  • Remove all related tests

PR should go to dev
@merelcht merelcht mentioned this issue Dec 14, 2022
Closed
18 tasks
This was referenced Sep 18, 2023
Closed
Merged
@noklam
Copy link
Contributor

noklam commented Sep 22, 2023

Bumping this to 3 now. I know it's not gonna be straight forward 😁. See https://github.com/kedro-org/kedro/actions/runs/6274519060/job/17040074039?pr=3057, I remember I have encountered something similar when move to kedro-datasets, there are some code path only triggered in the datasets test, mostly related to partitionedDataset if I remember correctly.

We may either have to move/duplicate some test to kedro/io or write new tests.

@noklam
Copy link
Contributor

noklam commented Sep 25, 2023

Close by #3067 , follow up with #3068

@noklam noklam closed this as completed Sep 25, 2023
@astrojuanlu
Copy link
Member

#3057

@astrojuanlu astrojuanlu mentioned this issue Nov 28, 2023
Closed
@astrojuanlu astrojuanlu mentioned this issue Feb 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@noklam noklam

Labels
None yet
Projects
None yet
Milestone
Package kedro.extras.datasets into it...
Development

No branches or pull requests
3 participants
@astrojuanlu @noklam @merelcht