Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop package_name argument in KedroSession.create in 0.19 #1892

Closed
3 tasks
noklam opened this issue Oct 3, 2022 · 1 comment · Fixed by #3372
Closed
3 tasks

Drop package_name argument in KedroSession.create in 0.19 #1892

noklam opened this issue Oct 3, 2022 · 1 comment · Fixed by #3372
Assignees

Comments

@noklam
Copy link
Contributor

noklam commented Oct 3, 2022

Description

  • Drop package_name argument in KedroSession.create in 0.19
  • Updating all the test cases without the project_name
  • Remove all internal calls with package_name

Context

  • The package_name argument provided in KedroSession.create() doesn't do anything, which is confusing to users. This argument should be removed, but since that is a breaking change it will happen in 0.19
  • The workaround to run a run within a session is valid, but it's important to note that bootstrap_project is only meant for configuring a project that hasn't been packaged. When working with a packaged project configure_project should be used instead.
  • The problem with the main() method is that it currently returns an exit code, so downstream processes can't do anything with it.

Originally posted by @MerelTheisenQB in #1423 (comment)

@noklam noklam added this to the 0.19 milestone Oct 3, 2022
@merelcht merelcht removed this from the 0.19 milestone Oct 25, 2022
@merelcht merelcht moved this to To Do in Kedro Framework Oct 25, 2023
@SajidAlamQB SajidAlamQB moved this from To Do to In Progress in Kedro Framework Nov 28, 2023
@SajidAlamQB SajidAlamQB moved this from In Progress to In Review in Kedro Framework Nov 30, 2023
@SajidAlamQB SajidAlamQB linked a pull request Nov 30, 2023 that will close this issue
7 tasks
@SajidAlamQB
Copy link
Contributor

Completed in: #3372

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants