-
Notifications
You must be signed in to change notification settings - Fork 909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace Pipeline with pipeline across all tests #1833
Comments
This is my first issue and I'd like to be assigned |
Excellent! So happy to have you onboard @ziyad00 |
Is this issue still open? I'd be happy to pick up the work for it |
I believe it is indeed still open. @jmholzer? |
Hey @adamfrly, yes this issue is still open 🙂 Awesome! Would be glad to have your contribution. |
From what I recall I think all the remaining instances of |
@AntonyMilneQB yes! This is exactly right 🙂. As soon as we import |
Sounds great! I was thinking of something along the lines of |
Description
Currently,
Pipeline
is used to instantiate objects of this class across the testing code base. This should be updated to use thepipeline
factory inkedro.pipeline.modular_pipeline
.Context
This comes from @AntonyMilneQB's comment on #1795 suggesting that these changes be made for the test files modified for that feature.
The text was updated successfully, but these errors were encountered: