-
Notifications
You must be signed in to change notification settings - Fork 909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
logs print credentials if error in catalog with Rich Logging show_locals=True #1712
Comments
Thank you @Debbby57 for raising this - we'll look into how we can fix this. |
Hi @Debbby57, thanks very much for raising this. Just to check: is the only place that This is a side-effect of us recently (in 0.18.2) switching to using rich tracebacks for exception handling. We hadn't thought that this would cause problems like you've seen here, sorry! Just for now, a quick fix would be to add the following lines to your project settings.py file:
This will keep the same rich exception handling but no longer show the local variables (since Longer term, I think the only fix here would be to set The alternative is we try and raise a PR in rich to add some sort of |
thank you very much for your reply ! The fix you propose works fine :) I confirm that my credentials only appear in the "locals" boxes. From a safety point of view, I am really not comfortable to print credentials by default. |
Description
I run a pipeline but I made a mistake with a credentials key for fsspec (I used
HOST
instead ofhost
). Kedro crashes (I agree) but in the logs, all my credentials have been printed. Those credentials for this dataset are printed multiple times but all my credentials were printed too.Context
Steps to Reproduce
HOST
instead of `host)Expected Result
the log should hide credentials.
Actual Result
the log prints all credentials.
Your Environment
Include as many relevant details about the environment in which you experienced the bug:
python -V
): 3.9.13The text was updated successfully, but these errors were encountered: