Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix lambda function in demo-project #866

Merged
merged 1 commit into from
May 26, 2022
Merged

Fix lambda function in demo-project #866

merged 1 commit into from
May 26, 2022

Conversation

antonymilne
Copy link
Contributor

@antonymilne antonymilne commented May 25, 2022 •
edited
Loading

Description

#851 added a lambda function to the demo-project, which shows fine in kedro-viz but breaks kedro run with ValueError: Pipeline input(s) {'ingestion.x'} not found in the DataCatalog. I've fixed it.

QA notes

kedro run now works.

Checklist

  • Read the contributing guidelines
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added new entries to the RELEASE.md file
  • Added tests to cover my changes

@antonymilne antonymilne requested a review from tynandebold May 25, 2022 14:55
@antonymilne antonymilne requested a review from limdauto as a code owner May 25, 2022 14:55
tynandebold
tynandebold approved these changes May 26, 2022
View reviewed changes
Copy link
Member

@tynandebold tynandebold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much

@tynandebold tynandebold merged commit 6cee1b7 into main May 26, 2022
@tynandebold tynandebold deleted the chore/fix-lambda branch May 26, 2022 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tynandebold tynandebold tynandebold approved these changes

@limdauto limdauto limdauto approved these changes

@rashidakanchwala rashidakanchwala Awaiting requested review from rashidakanchwala rashidakanchwala is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@antonymilne @limdauto @tynandebold