Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[KED-3060] Create viz version graphql endpoint #727
[KED-3060] Create viz version graphql endpoint #727
Changes from 8 commits
cb80537
bbbed4f
9b63ffa
cdd45d2
c5b5828
0f15e68
5ed1996
41044db
900ccf7
45cae05
b528387
1318c49
988a75a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
naming this as
Current
might be more relevant as I understand there can be multiple versions of a package installed in a python environment ( @limdauto @AntonyMilneQB can correct me if I'm wrong)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there can't be multiple versions of a package installed in the same python environment. There can be many environments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for clarifying @limdauto - on that note, I've heard that it is possible to install multiple versions of a package by specifying it to be installed in a different directory other than the default
site-packages
? ( not that it is a common use case at all) Again, I'm no python dev, so you know best 😄On the subject,
Current
version to me sounds more intuitive as we normally refer to 'current' and 'latest' versions - curious to hear your thoughts.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reason I didn't like
current
is because I didn't know what it was describing, and it seemed like it could describe both. As in: is it the current version the user has installed? Or is it the current version that's released on PyPI?With
installed
andlatest
I think it's more clear. It might even be clearer if it'sinstalled
andlatestRelease
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also don't like
current
for the same reason as @tynandebold mentioned.installed
andlatest
make most sense to me.With that said, we are already using
current
as the variable name where we do the CLI nudge. So whatever we go for, let's be consistent so we don't have current, latest and installed in the codebase.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@studioswong you could indeed install different version of the same Python package to different locations. But when we do
from kedro_viz import __version__
, it will be well-defined and import from only one installation of the package (the precedence of different locations is given bysys.path
in Python). So it does make sense to refer to the "installed Python package" as a unique entity.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm sticking with
installed
andlatest
. I'll change in the cli files, too.