Fix websocket protocol for demo site #719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tynandebold
requested changes
Jan 26, 2022
| @@ -13,6 +13,8 @@ const wsHost = | |||
| ? 'localhost:4142' | |||
| : window.location.host; | |||
|
|
|||
| const wsProtocol = window.location.protocol === 'https:' ? 'wss' : 'ws'; | |||
There was a problem hiding this comment.
Need to use this on line 19.
There was a problem hiding this comment.
Oops the file wasn't saved and commited. Nice catch.
|
Proof that this is working nicely: https + wss in the screenshot |
Signed-off-by: Lim Hoang <[email protected]>
tynandebold
reviewed
Jan 26, 2022
RELEASE.md
Outdated
Comment on lines
3
to
9
| <!-- | ||
| Use the sections below to add notes for the next release. | ||
| Please follow the established format: | ||
| - Keep each note concise - ideally commit title length | ||
| - Use present tense (e.g. 'Add new feature') | ||
| - Include the ID number for the related PR (or PRs) in parentheses | ||
| --> |
There was a problem hiding this comment.
I think we should keep this in though.
idanov
approved these changes
Jan 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The demo site is served through HTTPS so we need
wssfor websocket.Development notes
Lightsail does have a healthcheck for the index. The trouble is if websocket fails the server still returns an HTTP 200. We might need to look at a fix in apollo client to make it fail more gracefully and doesn't blow up the entire app.
QA notes
Checklist
RELEASE.mdfile