Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: remove env renaming in CircleCI step #718

Merged
merged 1 commit into from
Jan 26, 2022
Merged

Chore: remove env renaming in CircleCI step #718

merged 1 commit into from
Jan 26, 2022

Conversation

tynandebold
Copy link
Member

Description

We're simplifying our setup and these lines are no longer needed.

Checklist

  • Read the contributing guidelines
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added new entries to the RELEASE.md file
  • Added tests to cover my changes

limdauto
limdauto approved these changes Jan 26, 2022
View reviewed changes
Copy link
Collaborator

@limdauto limdauto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tynandebold tynandebold changed the title Chore: remove env renaming in CircleCI steps Chore: remove env renaming in CircleCI step Jan 26, 2022
@tynandebold tynandebold merged commit 779f455 into main Jan 26, 2022
@tynandebold tynandebold deleted the chore/remove-env-vars-renaming branch January 26, 2022 12:20
@studioswong studioswong mentioned this pull request Jan 26, 2022
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@idanov idanov idanov approved these changes

@limdauto limdauto limdauto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tynandebold @limdauto @idanov