[KED-2948] Fixed params as prefix issue for datasets #707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rashida Kanchwala <[email protected]>
rashidakanchwala
requested review from
antonymilne,
studioswong and
tynandebold
Signed-off-by: Rashida Kanchwala <[email protected]>
Signed-off-by: Rashida Kanchwala <[email protected]>
Signed-off-by: Rashida Kanchwala <[email protected]>
Signed-off-by: Rashida Kanchwala <[email protected]>
Signed-off-by: Rashida Kanchwala <[email protected]>
Signed-off-by: Rashida Kanchwala <[email protected]>
Signed-off-by: Rashida Kanchwala <[email protected]>
Signed-off-by: Rashida Kanchwala <[email protected]>
| def as_dict(self) -> Dict[str, ModularPipelineNode]: | ||
| """Return the repository as a dictionary.""" | ||
| return self.tree | ||
| """`kedro_viz.data_access.repositories.modular_pipelines` |
There was a problem hiding this comment.
No idea, why github is not ignoring this since it's exact same !!
There was a problem hiding this comment.
Mysterious! Maybe pulling main in will fix it?
There was a problem hiding this comment.
Glad I'm not the only going crazy. I was looking through the blames and couldn't tell what changed!
Signed-off-by: Rashida Kanchwala <[email protected]>
antonymilne
approved these changes
Jan 20, 2022
rashidakanchwala
deleted the
KED-2948/fix/params_prefix_for_non_param_datasets
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Rashida Kanchwala [email protected]
Description
Fixes #621.
Development notes
'params:' and 'parameters' are reserved keywords. If anyone uses them in Kedro. The node will be considered as a parameter.
This issue has been fixed, so if you rename a dataset to param_<dataset_name>, it will still display as a dataset
QA notes
Checklist
RELEASE.mdfile