Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KED-3029] Fixed the order of runsList in experiment tracking #691

Merged
merged 4 commits into from
Jan 11, 2022

Conversation

rashidakanchwala
Copy link
Contributor

Description

Jira Ticket - https://jira.quantumblack.com/browse/KED-3029

Development notes

Run's list now displayed from the latest runs to oldest runs.

QA notes

Checklist

  • Read the contributing guidelines
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added new entries to the RELEASE.md file
  • Added tests to cover my changes

Signed-off-by: Rashida Kanchwala <[email protected]>
@rashidakanchwala rashidakanchwala force-pushed the KED3029/run-list-ordered branch from 91404e8 to abe6d54 Compare January 10, 2022 18:18
Signed-off-by: Rashida Kanchwala <[email protected]>
@rashidakanchwala rashidakanchwala force-pushed the KED3029/run-list-ordered branch from 1ce10d7 to 726aa4a Compare January 11, 2022 11:08
Copy link
Collaborator

@limdauto limdauto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rashidakanchwala rashidakanchwala merged commit 56a3fa1 into main Jan 11, 2022
@rashidakanchwala rashidakanchwala deleted the KED3029/run-list-ordered branch January 11, 2022 14:40
@studioswong
Copy link
Contributor

One thing I noticed is that there is no tests for this on the BE - @rashidakanchwala can you please add the relevant test to ensure the data does gets returned in the right order? Thank you. ( cc @limdauto )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants