[KED-3030] Fix for plotly.JSONDataSet icon #684
Conversation
rashidakanchwala
changed the title
There was a problem hiding this comment.
I'm not sure I'm looking at the right thing. When I view our demo site and look at Price Histogram it already has the Plotly icon, doesn't it?
Hi, it's because the demo site for some reason has Price Histogram as plotly.PlotlyDataSet which always had the plotly icon. It was plotly.JSONDataSet that did not. Joel's spaceflight tutorial uses JSONDataSet, so you can test using it - https://github.com/datajoely/modular-spaceflights. I have also attached a full screenshot as proof where in the metadata panel you can see the data type as JSONDataSet |
Got it! Thanks :) |
RELEASE.md
Outdated
| <!-- | ||
| Use the sections below to add notes for the next release. | ||
| Please follow the established format: | ||
| - Keep each note concise - ideally commit title length | ||
| - Use present tense (e.g. 'Add new feature') | ||
| - Include the ID number for the related PR (or PRs) in parentheses | ||
| --> |
There was a problem hiding this comment.
This shouldn't be deleted as it's guidelines for the release notes.
Signed-off-by: Rashida Kanchwala <[email protected]>
Signed-off-by: Rashida Kanchwala <[email protected]>
Signed-off-by: Rashida Kanchwala <[email protected]>
Signed-off-by: Rashida Kanchwala <[email protected]>
* add pencil/edit icon; create run-details modal; open/close of that modal working * add basic text area in modal * local creation of an Input component * create ui folder and add generic textarea and input components * use text-decoration for active state * modal gets dynamic data from selected run * run details modal tests * rename textarea to input and use that in modal; remove other input component * test written for input component * updates based on PR review * Rashida's PR reviews; hide edit run button when comparison view is on * fix typos; update general edit run modal behavior * add runDetails mutation * remove searchable text; add client to mutation so tests pass * don't format schema * Update backend schema * Fixed mypy error * fixed mypy2 * fixed pylint error * update to id from runId in graphql response * update run_id to id in response -2 * UpdateRunDetails returns Run * correct response from updateRunDetails mutation; reset mutation on error; use placeholder for notes field * fix run-selection anomoly * fix failing RunDetailsModal test * update mutation response * use the Modal component from the repo, not the QB UI one * fix failing RunDetailsModal test * remove working_directory from circleci * add working_directory to build_38 * use tmp folder instead of repo * revert and use arch * revert by removing working_directory from build_38 and test build again * clear input on trigger; remove arch from circle ci Co-authored-by: Rashida Kanchwala <[email protected]> Signed-off-by: Rashida Kanchwala <[email protected]>
Signed-off-by: Rashida Kanchwala <[email protected]>
Signed-off-by: Rashida Kanchwala <[email protected]>
* updated new data flow diagram with architecture docs * update architecture docs wording as per suggested * added in note formatting * minor wording changes Signed-off-by: Rashida Kanchwala <[email protected]>
rashidakanchwala
force-pushed
the
KED-3030/bug/fix-plotlyJSONDataSet-icon
branch
from
7acfc07 to
b9d27bf
Compare
Description
Jira Ticket - https://jira.quantumblack.com/browse/KED-3030
Development notes
Updated shortTypeMapping to also map plotly.JSONDataset to 'plotly' so that correct icon can be rendered
QA notes
Checklist
RELEASE.mdfile