Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KED 2534] Remove code panel flag #404

Closed
wants to merge 9 commits into from

Conversation

rashidakanchwala
Copy link
Contributor

@rashidakanchwala rashidakanchwala commented Mar 24, 2021

Description

Code panel is now a default feature of Kedro Viz. Hence, the code panel flag is no longer required

Development notes

Updated config, readme, and index.js to remove the flag.

QA notes

Ran npm t successfully

Checklist

  • Read the contributing guidelines
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added new entries to the RELEASE.md file
  • Added tests to cover my changes

Legal notice

  • I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":

  • I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.

  • I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorised to submit this contribution on behalf of the original creator(s) or their licensees.

  • I certify that the use of this contribution as authorised by the Apache 2.0 license does not violate the intellectual property rights of anyone else.

rashidakanchwala and others added 8 commits March 16, 2021 17:24
This was unused reducer in the visible.js leftover from a previous changed. layers.visible reducer is used to store the state of layers.
Deleted description (docstring) from meta_data panel as it already present in the code panel.
…ntumblacklabs/kedro-viz into fix/delete-description-from-metadata
Code panel is now a default feature hence the flag is not required.
@rashidakanchwala rashidakanchwala deleted the fix/remove-code-panel-flag branch March 24, 2021 18:10
@studioswong studioswong mentioned this pull request Apr 16, 2021
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants