Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove leftover visible layer reducer #399

Merged
merged 2 commits into from
Mar 18, 2021

Conversation

rashidakanchwala
Copy link
Contributor

@rashidakanchwala rashidakanchwala commented Mar 17, 2021

Description

This was an unused reducer in the visible.js. that was leftover from a previous change.
We currently use layers.visible reducer to store the state of layers and the app work's fine if we remove the above code.

Development notes

Couple of line deletion.

QA notes

No functionality changes

Checklist

  • Read the contributing guidelines
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added new entries to the RELEASE.md file
  • Added tests to cover my changes

Legal notice

  • I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":

  • I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.

  • I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorised to submit this contribution on behalf of the original creator(s) or their licensees.

  • I certify that the use of this contribution as authorised by the Apache 2.0 license does not violate the intellectual property rights of anyone else.

This was unused reducer in the visible.js leftover from a previous changed. layers.visible reducer is used to store the state of layers.
Copy link
Contributor

@studioswong studioswong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello Rashida!!! Congrats on your first PR on Kedro-viz - good spot!

Copy link
Contributor

@richardwestenra richardwestenra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@richardwestenra
Copy link
Contributor

richardwestenra commented Mar 18, 2021

I can't figure out why CI isn't running on this PR. If we can't get CI tests to run I'm happy for us to merge it if all the tests pass locally, but we should ideally try to get it working first.

@limdauto Do you have any ideas?

@studioswong
Copy link
Contributor

studioswong commented Mar 18, 2021

I can't figure out why CI isn't running on this PR. If we can't get CI tests to run I'm happy for us to merge it if all the tests pass locally, but we should ideally try to get it working first.

@limdauto Do you have any ideas?

@richardwestenra I just merged main and pushed this branch just to see if this could trigger a build on CI and looks like the build is running now. I notice that the previous push didn't trigger any run on circleCI at all - I'm not entirely sure if this is due to a permissions issue, might be worth a look?

@richardwestenra richardwestenra merged commit cc186a2 into main Mar 18, 2021
@richardwestenra richardwestenra deleted the fix/remove-visible-layer-reducer branch March 18, 2021 18:44
@studioswong studioswong mentioned this pull request Apr 16, 2021
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants