[KED-2492] Update store functions for new modular pipeline data #391
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
related ticket: KED-2492
This is the initial set up work to update the store functions to allow the newly added
modular_pipeline
field from the pipeline data to be added in the state as well ( as a seperate field as well as part of the node data)Development notes
I have added:
modular_pipeline
field under the state to store the modular pipeline data ( naming following how we named 'pipeline), and a new
modular_pipelinesfield for the node state data ( naming of this field also following the pattern of how other fields are name for the node fields, such as
pipelines`)addModularPipeline
function to add the modular pipeline by id - it will also check if any existing modular pipelines with the same id exists.Please note that I had not added any tests relating to the addition of the
modular_pipelines
field in the node as I observed that there are no existing test to test the specifics ofaddNode
function (nor any node data) withinnormalize-data.js
- in following the existing pattern in the codebase, the existence of this additional field will be covered by further tests set up under the tests for the selectors that will be set up in the ticket for the proceeding work under KED-2436QA notes
This could be tested by testing the state data after the pipeline data has been loaded.
Checklist
RELEASE.md
fileLegal notice
I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":
I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.
I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorised to submit this contribution on behalf of the original creator(s) or their licensees.
I certify that the use of this contribution as authorised by the Apache 2.0 license does not violate the intellectual property rights of anyone else.