Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KED-2492] Update store functions for new modular pipeline data #391

Merged

Conversation

studioswong
Copy link
Contributor

@studioswong studioswong commented Mar 10, 2021

Description

related ticket: KED-2492

This is the initial set up work to update the store functions to allow the newly added modular_pipeline field from the pipeline data to be added in the state as well ( as a seperate field as well as part of the node data)

Development notes

I have added:

  1. A new modular_pipeline field under the state to store the modular pipeline data ( naming following how we named 'pipeline), and a new modular_pipelinesfield for the node state data ( naming of this field also following the pattern of how other fields are name for the node fields, such aspipelines`)
  2. A addModularPipeline function to add the modular pipeline by id - it will also check if any existing modular pipelines with the same id exists.
  3. Modified the reducer to include the newly added modular pipeline field in the state
  4. tests to test the newly added modular pipeline field.

Please note that I had not added any tests relating to the addition of the modular_pipelines field in the node as I observed that there are no existing test to test the specifics of addNode function (nor any node data) within normalize-data.js - in following the existing pattern in the codebase, the existence of this additional field will be covered by further tests set up under the tests for the selectors that will be set up in the ticket for the proceeding work under KED-2436

QA notes

This could be tested by testing the state data after the pipeline data has been loaded.

Checklist

  • Read the contributing guidelines
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added new entries to the RELEASE.md file
  • Added tests to cover my changes

Legal notice

  • I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":

  • I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.

  • I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorised to submit this contribution on behalf of the original creator(s) or their licensees.

  • I certify that the use of this contribution as authorised by the Apache 2.0 license does not violate the intellectual property rights of anyone else.

@studioswong studioswong requested a review from bru5 March 10, 2021 12:55
@idanov idanov changed the title [KED-2492]Update store functions for new modular pipeline data [KED-2492] Update store functions for new modular pipeline data Mar 10, 2021
Copy link
Contributor

@richardwestenra richardwestenra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect. Great job! :)

@studioswong studioswong merged commit 02c39bb into main Mar 12, 2021
@studioswong studioswong deleted the feature/KED-2492-update-store-functions-modular-pipeline branch March 12, 2021 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants