-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[KED-2144] Scrolling on Kedro-Viz throws errors when pipeline is empty #342
Merged
studioswong
merged 8 commits into
main
from
fix/KED-2144-fix-empty-pipeline-scroll-error
Jan 11, 2021
Merged
Changes from 6 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
8179e2e
added checks for infinity or NaN values for zoom
studioswong a4fa30b
further include zoom actions with checks
studioswong 4cc22cd
moved and added comments
studioswong 7a2e72b
added tests to test for invalid zoom values
studioswong 7139cb3
update according to PR comment
studioswong 1cf3fb9
deleted tests ( more proper test set up for flowchart zoom will comme…
studioswong 2b68dc5
Merge branch 'main' into fix/KED-2144-fix-empty-pipeline-scroll-error
studioswong 75a04cd
move check before scaling operations
studioswong File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey do you mind moving this up to the top of the function (immediately after line 202)?