Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CSS custom properties #319

Merged
merged 2 commits into from
Nov 27, 2020
Merged

Conversation

richardwestenra
Copy link
Contributor

Description

Fixes a couple of regressions introduced in #301

Development notes

  1. Fix invalid syntax in gradient colour - I had left in a , 1 when converting from rgba to var.
  2. Invert filter-indicator-off colours - I'd gotten these confused because the light colours were suppose to be used on the dark themes and vice versa

QA notes

Fixes node-list tag icon colours on inactive tags when another tag is active

Checklist

  • Read the contributing guidelines
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added new entries to the RELEASE.md file
  • Added tests to cover my changes

Legal notice

  • I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":

  • I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.

  • I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorised to submit this contribution on behalf of the original creator(s) or their licensees.

  • I certify that the use of this contribution as authorised by the Apache 2.0 license does not violate the intellectual property rights of anyone else.

I'd gotten these confused because the light colours were suppose to be used on the dark themes and vice versa
@richardwestenra richardwestenra merged commit efde16b into main Nov 27, 2020
@richardwestenra richardwestenra deleted the fix/css-custom-properties-fixes branch November 27, 2020 11:25
@richardwestenra richardwestenra mentioned this pull request Dec 16, 2020
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants