Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI by making sure we have latest botocore in e2e tests #304

Merged
merged 2 commits into from
Nov 12, 2020
Merged

Conversation

limdauto
Copy link
Collaborator

@limdauto limdauto commented Nov 12, 2020

Description

Development notes

QA notes

Checklist

  • Read the contributing guidelines
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added new entries to the RELEASE.md file
  • Added tests to cover my changes

Legal notice

  • I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":

  • I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.

  • I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorised to submit this contribution on behalf of the original creator(s) or their licensees.

  • I certify that the use of this contribution as authorised by the Apache 2.0 license does not violate the intellectual property rights of anyone else.

@limdauto limdauto requested a review from 921kiyo as a code owner November 12, 2020 17:05
Copy link
Contributor

@921kiyo 921kiyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@limdauto limdauto changed the title Fix CI by pinning urllib3 Fix CI by making sure we have latest botocore in e2e tests Nov 12, 2020
@limdauto limdauto merged commit 06ae709 into main Nov 12, 2020
@limdauto limdauto deleted the fix-ci branch November 12, 2020 17:49
@richardwestenra richardwestenra mentioned this pull request Nov 16, 2020
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants