Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KED-2181] Deprecate pipelines flag #294

Merged
merged 1 commit into from
Nov 4, 2020

Conversation

richardwestenra
Copy link
Contributor

@richardwestenra richardwestenra commented Nov 2, 2020

Description

The feature flag was being used to allow us to work on this feature while it was still a work-in-progress, and have releases go out without it being ready, so that it was hidden from users.

This PR is to remove the flag, so that this feature can be officially released. This should be merged only once the new modular pipelines selector is ready to ship

Checklist

  • Read the contributing guidelines
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added new entries to the RELEASE.md file
  • Added tests to cover my changes

Legal notice

  • I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":

  • I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.

  • I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorised to submit this contribution on behalf of the original creator(s) or their licensees.

  • I certify that the use of this contribution as authorised by the Apache 2.0 license does not violate the intellectual property rights of anyone else.

Copy link
Contributor

@studioswong studioswong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for the context!

@richardwestenra richardwestenra merged commit 3218e1a into main Nov 4, 2020
@richardwestenra richardwestenra deleted the feature/deprecate-pipelines-flag branch November 4, 2020 19:30
@richardwestenra richardwestenra mentioned this pull request Nov 9, 2020
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants