Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display Dataset Type with Library Prefix in Metadata Panel #2136

Merged
merged 4 commits into from
Oct 14, 2024

Conversation

SajidAlamQB
Copy link
Contributor

Description

Related to: #2071

The dataset type in the metadata panel was not clear for example, If I have a polars.CSVDataset and a pandas.CSVDataset, both display just CSVDataset.

Development notes

Updated the logic to include the library name as a prefix (e.g., pandas.CSVDataset), making it clearer to differentiate between datasets.

image

QA notes

Tested manually with various dataset types (e.g., pandas, polars) to ensure proper display.

Checklist

  • Read the contributing guidelines
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added new entries to the RELEASE.md file
  • Added tests to cover my changes

Signed-off-by: Sajid Alam <[email protected]>
Copy link
Contributor

@rashidakanchwala rashidakanchwala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SajidAlamQB SajidAlamQB requested a review from Huongg October 14, 2024 09:48
@SajidAlamQB SajidAlamQB merged commit 90355f8 into main Oct 14, 2024
24 checks passed
@SajidAlamQB SajidAlamQB deleted the clearer-dataset-types branch October 14, 2024 10:40
@SajidAlamQB SajidAlamQB mentioned this pull request Oct 14, 2024
1 task
@jitu5 jitu5 mentioned this pull request Nov 20, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants