Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace CircleCI badge in readme with GitHub actions #2124

Merged
merged 2 commits into from
Oct 3, 2024

Conversation

tynandebold
Copy link
Member

@tynandebold tynandebold commented Oct 2, 2024

Description

Resolves #2114

QA Notes

See the updated README here: https://github.com/kedro-org/kedro-viz/tree/chore/replace-circleci-badge-with-gh-actions

Checklist

  • Read the contributing guidelines
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added new entries to the RELEASE.md file
  • Added tests to cover my changes

Copy link
Contributor

@ravi-kumar-pilla ravi-kumar-pilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !! Thank you @tynandebold

@deepyaman deepyaman changed the title Replace CircleCI badge in readme with GitHub actions Replace CircleCI badge in readme with GitHub Actions Oct 2, 2024
@rashidakanchwala
Copy link
Contributor

Wooo, first hacktoberfest PR :D -- good to see u on this side @tynandebold

Copy link
Contributor

@Huongg Huongg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amazing, thank you @tynandebold ❤️

@astrojuanlu
Copy link
Member

How many approvals does a PR need 😅

@tynandebold tynandebold changed the title Replace CircleCI badge in readme with GitHub Actions Replace CircleCI badge in readme with GitHub actions Oct 3, 2024
@tynandebold tynandebold merged commit 34bcb55 into main Oct 3, 2024
27 checks passed
@tynandebold tynandebold deleted the chore/replace-circleci-badge-with-gh-actions branch October 3, 2024 19:56
@rashidakanchwala rashidakanchwala mentioned this pull request Nov 21, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace CircleCI status badge with Github Action on Readme
6 participants