-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce get_kedro_project_json_data
function for VSCode integration
#2049
Conversation
Signed-off-by: Jitendra Gundaniya <[email protected]>
Signed-off-by: Jitendra Gundaniya <[email protected]>
Signed-off-by: Jitendra Gundaniya <[email protected]>
Signed-off-by: Jitendra Gundaniya <[email protected]>
Signed-off-by: Jitendra Gundaniya <[email protected]>
And also, would it make sense longer term to extract that functionality to a self-contained package? Thinking for example of the defunct https://github.com/AlpAribal/kedro-inspect/ |
This definitely make sense, but I would like to see this happen at a core level where https://nbviewer.org/github/noklam/kedro-viz-lite/blob/main/nbs/10_demo.ipynb, regardless of a separate package /refactoring, I would like to see this can be done in a notebook, where I can easily convert an existing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. thanks!
* Load data functions move out of server Signed-off-by: Jitendra Gundaniya <[email protected]> * Refactor Signed-off-by: Jitendra Gundaniya <[email protected]> * Lint fix Signed-off-by: Jitendra Gundaniya <[email protected]> * lint fix Signed-off-by: Jitendra Gundaniya <[email protected]> --------- Signed-off-by: Jitendra Gundaniya <[email protected]>
Description
Resolves #2021
To get current Kedro project JSON data required by Kedro-Viz React component when running inside VSCode, We introduce
get_kedro_project_json_data
function inresponses.py
which returns current Kedro project JSON data.Development notes
get_kedro_project_json_data
function,load_and_populate_data
will be calledChecklist
RELEASE.md
file