-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reload the page resets back the default pipeline #2041
Conversation
Signed-off-by: Sajid Alam <[email protected]>
One issue I noticed was when you're in any other pipeline view except the default and you click a node when the page refreshes the node is not highlighted anymore and the metadata panel doesn't open. In the default view reloading with a node selected keeps it highlighted and opens metadata panel. |
Signed-off-by: Sajid Alam <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
works for me. thanks
hey @SajidAlamQB I think the pipeline bug is fixed now but as you said there's other bug about the selected node is not highlighted and metadata panel is not opened. And even in the default pipeline, the node is not highlighted even the meta data panel opens 🤔 |
I'm not able to see the bug with the default pipeline, but it does exist with the other pipeline views. I'm not too sure what the best fix for this is, do you have any ideas? |
hey @SajidAlamQB I can still see the issue from my side. I think it might be related to your previous issue. Have you looked at |
Signed-off-by: Sajid Alam <[email protected]>
Signed-off-by: Sajid Alam <[email protected]>
This PR also fixes two bugs:
|
Signed-off-by: Sajid Alam <[email protected]>
Signed-off-by: Sajid Alam <[email protected]>
Signed-off-by: Sajid Alam <[email protected]>
Signed-off-by: rashidakanchwala <[email protected]>
Signed-off-by: rashidakanchwala <[email protected]>
Signed-off-by: rashidakanchwala <[email protected]>
Signed-off-by: Sajid Alam <[email protected]>
…-viz into feat/reload-page Signed-off-by: Sajid Alam <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's working from my side, thanks @SajidAlamQB for the changes 👍
@SajidAlamQB have you tested with this scenario #1879 ? |
I've tested it and it now opens on this page in Incognito: in Safari: With the following in
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @SajidAlamQB and @rashidakanchwala.
Description
Related to: #1997
When you're in any other pipeline view rather the default pipeline, if you load the URL again, it will reset to the default page.
Development notes
Introduced the
modularPipelineTree
logic to ensure that only the children of a modular pipeline are expanded.Added a check to avoid overwriting the active pipeline if one is already set.
Removed the
urlParams
frompreparePipelineState
in thegetInitialState
method, as they were causing unexpected overwrites.Checklist
RELEASE.md
file