Feature/slicing pipeline add notification #2003

SajidAlamQB · 2024-07-26T12:37:39Z

Description

This feature will show a notification to kedro users to Hold Shift + Click on another node to slice pipeline. Moreover, the order in which nodes are selected to should not matter and be resolved Programatically.

Development notes

When testing on your machine locally, or through gitpod, please note that this PR only covers the functionalities below:

Notification on First Node Click: When I click on the first node, a notification should appear. This behavior should not occur when clicking on a pipeline (is it referred to as "pipeline" or "modular pipeline"?).
Second Node Click with Shift: If I hold the Shift key and click on a second node, the metadata should close immediately, and the notification should disappear.
when selecting a node from bottom to top, the order should be updated according to --from-node=bottom-node-id --to-node=top-node-id

Notification bar:

Checklist

Read the contributing guidelines
Opened this PR as a 'Draft Pull Request' if it is work-in-progress
Updated the documentation to reflect the code changes
Added new entries to the RELEASE.md file
Added tests to cover my changes

src/components/flowchart/flowchart.js

Huongg

hey @SajidAlamQB, The code is looking pretty good! 🔥

I did notice one thing: the notification transition is a bit glitchy. In the video, it looks like it gets stuck and doesn't move to the left smoothly in one transition, but it seems fine when you shift-hold and click. 🤔 I wonder if the translateX isn't being applied immediately or if the transformX calculated number is changing too frequently.

notification.transform.mov

src/components/flowchart/flowchart.js

src/components/flowchart/components/sliced-pipeline-action-bar/sliced-pipeline-action-bar.js

src/components/flowchart/flowchart.js

SajidAlamQB · 2024-08-07T13:00:05Z

I did notice one thing: the notification transition is a bit glitchy. In the video, it looks like it gets stuck and doesn't move to the left smoothly in one transition, but it seems fine when you shift-hold and click.

I am not able to see this on my end, the transition seems smooth when we click away and when we shift + click.

Huongg · 2024-08-07T16:02:07Z

I did notice one thing: the notification transition is a bit glitchy. In the video, it looks like it gets stuck and doesn't move to the left smoothly in one transition, but it seems fine when you shift-hold and click.

I am not able to see this on my end, the transition seems smooth when we click away and when we shift + click.

hey I've updated the transition timing from 0.7s to 0.2s and it looks a lot smoother from my side now. I think 0.7s was to slow so it's showing all the different movements, that's why i can see it's a bit glitchy from myside

stephkaiser · 2024-08-08T12:04:09Z

thanks Sajid! some comments from me:

the text colour in the tooltip notification component should be black-900 on dark UI, and white-0 on light UI
there seems to be an odd line at the end of the component, not sure if this is a bug or not

the tooltip notification closes when I click outside in the flowchart background area however, it doesn't get dismissed if i click on the X close button in the metadata panel, or if i click on a pipeline group in the list panel, or on the expand/collapse button. The notification is still there and persists

when selecting from bottom to top - after having selected a from and to node, when holding shift to select a different to node, it keeps the second selection (to node) but changes the from node. I expected the to node to change instead and keep the first from node selection, which is the same behaviour if selecting from top to bottom.

Let me know if any questions, thank you!

Huongg

hey @SajidAlamQB thanks for making all the changes, I've left some comments on how you can simplify the code and it will also help to fix the bug that we discussed earlier on the call. Let me know if you'd like to discuss them further on the call 😄

...omponents/flowchart/components/sliced-pipeline-action-bar/sliced-pipeline-action-bar.test.js

src/components/flowchart/flowchart.js

Signed-off-by: Sajid Alam <[email protected]>

jitu5 · 2024-08-13T15:17:53Z

@SajidAlamQB @Huongg
Have you considered the case where Kedro Viz used as React component? If I am not wrong we need to disable this functionality right ?

Huongg · 2024-08-13T16:13:27Z

@SajidAlamQB @Huongg Have you considered the case where Kedro Viz used as React component? If I am not wrong we need to disable this functionality right ?

good question, can we test it together tomorrow or sometimes this week? If it's working fine and this functionality is a part of flowchart, I don't see why we can't have this?

Do you see any risks we will take if we don't disable it @jitu5 ?

jitu5 · 2024-08-13T16:43:07Z

@SajidAlamQB @Huongg Have you considered the case where Kedro Viz used as React component? If I am not wrong we need to disable this functionality right ?

good question, can we test it together tomorrow or sometimes this week? If it's working fine and this functionality is a part of flowchart, I don't see why we can't have this?

Do you see any risks we will take if we don't disable it @jitu5 ?

@Huongg In most of the case When Kedro viz is used in embedded mode the main purpose is readonly or only flowchart visualisation, But I am not fully sure should we disabled it or not. @rashidakanchwala wdyt ?

jitu5

LGTM! Thanks @SajidAlamQB @Huongg

Huongg · 2024-08-13T17:41:51Z

@SajidAlamQB @Huongg Have you considered the case where Kedro Viz used as React component? If I am not wrong we need to disable this functionality right ?

good question, can we test it together tomorrow or sometimes this week? If it's working fine and this functionality is a part of flowchart, I don't see why we can't have this?
Do you see any risks we will take if we don't disable it @jitu5 ?

@Huongg In most of the case When Kedro viz is used in embedded mode the main purpose is readonly or only flowchart visualisation, But I am not fully sure should we disabled it or not. @rashidakanchwala wdyt ?

It's a bit tricky to determine if it's suitable for embedded mode without actually seeing it in action. In my mind, it seems like there wouldn't be any harm in including it in the standalone flowchart, since that's where most of the interaction happens. However, I can also understand the reasons for disabling it, especially if we decide to turn off the metadata panel.

src/components/flowchart/flowchart.js

Signed-off-by: Sajid Alam <[email protected]>

ravi-kumar-pilla · 2024-08-15T14:03:15Z

Hi @SajidAlamQB ,

As I was testing the fix for - #2003 (comment)
There seems to be another issue for the use case below [in gif] -

I click on a node -> the notification appears + metadata panel opens
I shift+click on another node -> the notification now says number of nodes selected + metadata panel closes
Now I click on a different node -> the notification appears + metadata panel opens (This was not working earlier and its fixed now. Thank you)
I shift+click on another node -> here is the issue [the notification now says 1 node selected + metadata panel closes]

Signed-off-by: Sajid Alam <[email protected]>

SajidAlamQB · 2024-08-15T14:34:47Z

I shift+click on another node -> here is the issue [the notification now says 1 node selected + metadata panel closes]

Should be fixed now.

ravi-kumar-pilla

LGTM !! Thank you @SajidAlamQB

…ication Signed-off-by: Sajid Alam <[email protected]>

Signed-off-by: Sajid Alam <[email protected]>

* set actions - filters Signed-off-by: Huong Nguyen <huongg1409@gmail> * set reducers - filters Signed-off-by: Huong Nguyen <huongg1409@gmail> * set reducers - filtered-pipeline Signed-off-by: Huong Nguyen <huongg1409@gmail> * user getFilteredPipeline in disabled Signed-off-by: Huong Nguyen <huongg1409@gmail> * set eslint Signed-off-by: Huong Nguyen <huongg1409@gmail> * first setup in flowchart Signed-off-by: Huong Nguyen <huongg1409@gmail> * include isDisabledViaFilters in disabled Signed-off-by: Huong Nguyen <huongg1409@gmail> * highlight multi-select nodes Signed-off-by: Huong Nguyen <huongg1409@gmail> * use local state instead Signed-off-by: Huong Nguyen <huongg1409@gmail> * remove extra action Signed-off-by: Huong Nguyen <huongg1409@gmail> * shifting the logic around for shift hold the node Signed-off-by: Huong Nguyen <huongg1409@gmail> * create a separate state for highlighting node Signed-off-by: Huong Nguyen <huongg1409@gmail> * firt working version of highlighting the node list Signed-off-by: Huong Nguyen <huongg1409@gmail> * remove the extra selector and action Signed-off-by: Huong Nguyen <huongg1409@gmail> * first draft of highlighting the node list Signed-off-by: Huong Nguyen <huongg1409@gmail> * hide the slicing button Signed-off-by: Huong Nguyen <huongg1409@gmail> * remove extra node selector Signed-off-by: Huong Nguyen <huongg1409@gmail> * set click outside to clear highlighting node Signed-off-by: Huong Nguyen <huongg1409@gmail> * slice pipeline component Signed-off-by: Huong Nguyen <huongg1409@gmail> * handle click on the third node Signed-off-by: Huong Nguyen <huongg1409@gmail> * reset filter nodes on click on the node list Signed-off-by: Huong Nguyen <huongg1409@gmail> * create utils function for filtering nodes in draw.js Signed-off-by: Huong Nguyen <huongg1409@gmail> * adding comments for componentDidUpdate Signed-off-by: Huong Nguyen <huongg1409@gmail> * remove un-used selectors Signed-off-by: Huong Nguyen <huongg1409@gmail> * rename filteredPipeline state and classname Signed-off-by: Huong Nguyen <huongg1409@gmail> * include filters in normalize data Signed-off-by: Huong Nguyen <huongg1409@gmail> * update normalize data Signed-off-by: Huong Nguyen <huongg1409@gmail> * test for reducers Signed-off-by: Huong Nguyen <huongg1409@gmail> * write test for selector Signed-off-by: Huong Nguyen <huongg1409@gmail> * changes to test the tests locally Signed-off-by: Huong Nguyen <huongg1409@gmail> * responsive cta button Signed-off-by: Huong Nguyen <huongg1409@gmail> * update failed test Signed-off-by: Huong Nguyen <huongg1409@gmail> * fix failed e2e tests Signed-off-by: Huong Nguyen <huongg1409@gmail> * adding transformX value for button Signed-off-by: Huong Nguyen <huongg1409@gmail> * add slice btn functionality Signed-off-by: Huong Nguyen <huongg1409@gmail> * remove unused props Signed-off-by: Huong Nguyen <huongg1409@gmail> * fix console error where the same id applies twice Signed-off-by: Huong Nguyen <huongg1409@gmail> * prevent resetting on onclick slice btn Signed-off-by: Huong Nguyen <huongg1409@gmail> * first working version of dilerting node list Signed-off-by: Huong Nguyen <huongg1409@gmail> * filtering node list on the left Signed-off-by: Huong Nguyen <huongg1409@gmail> * filter out modular pipeline if no nodes selected Signed-off-by: Huong Nguyen <huongg1409@gmail> * include reset button Signed-off-by: Huong Nguyen <huongg1409@gmail> * cy:test close the hint feature so can click on a node Signed-off-by: Huong Nguyen <huongg1409@gmail> * run command selector Signed-off-by: Huong Nguyen <huongg1409@gmail> * include command copier Signed-off-by: Huong Nguyen <huongg1409@gmail> * UI for command line Signed-off-by: Huong Nguyen <huongg1409@gmail> * avoid reseting when clicking on a node while filters is activated Signed-off-by: Huong Nguyen <huongg1409@gmail> * Add comment Signed-off-by: Huong Nguyen <huongg1409@gmail> * test to cover the run-command selector Signed-off-by: Huong Nguyen <huongg1409@gmail> * no holdshift click on nodes when filters are applied Signed-off-by: Huong Nguyen <huongg1409@gmail> * rename component and apply light theme Signed-off-by: Huong Nguyen <huongg1409@gmail> * move theme to shared variable Signed-off-by: Huong Nguyen <huongg1409@gmail> * fix typo Signed-off-by: Huong Nguyen <huongg1409@gmail> * close the hint feature in cy test Signed-off-by: Huong Nguyen <huongg1409@gmail> * lower case for one of the cy test Signed-off-by: Huong Nguyen <huongg1409@gmail> * remove pretify name as its already set Signed-off-by: Huong Nguyen <huongg1409@gmail> * update component name Signed-off-by: Huong Nguyen <huongg1409@gmail> * fix merge conflict and update classname for FilteredPipelineActionBar Signed-off-by: Huong Nguyen <huongg1409@gmail> * update classnames to match the new component name Signed-off-by: Huong Nguyen <huongg1409@gmail> * change the styling for filtered nodes Signed-off-by: Huong Nguyen <huongg1409@gmail> * refactor the logic to make it clearer Signed-off-by: Huong Nguyen <huongg1409@gmail> * temporary solution for styling highlighting state Signed-off-by: Huong Nguyen <huongg1409@gmail> * update name for selector and flowchart, draw and node-list components Signed-off-by: Huong Nguyen <huongg1409@gmail> * rename for state and action Signed-off-by: Huong Nguyen <huongg1409@gmail> * update name for action bar Signed-off-by: Huong Nguyen <huongg1409@gmail> * update name for css Signed-off-by: Huong Nguyen <huongg1409@gmail> * add notification Signed-off-by: Sajid Alam <[email protected]> * rename Signed-off-by: Sajid Alam <[email protected]> * Use SlicedPipelineActionBar Signed-off-by: Sajid Alam <[email protected]> * fix other merge conflict Signed-off-by: Huong Nguyen <huongg1409@gmail> * Update flowchart.test.js Signed-off-by: Sajid Alam <[email protected]> * styling for long run command Signed-off-by: Huong Nguyen <huongg1409@gmail> * adjust some styling Signed-off-by: Huong Nguyen <huongg1409@gmail> * remove the styling for node list Signed-off-by: Huong Nguyen <huongg1409@gmail> * update failed test and use visibleSidebar instead Signed-off-by: Huong Nguyen <huongg1409@gmail> * fix typo Signed-off-by: Huong Nguyen <huongg1409@gmail> * tidy up code Signed-off-by: Huong Nguyen <huongg1409@gmail> * update name in test Signed-off-by: Huong Nguyen <huongg1409@gmail> * add tests for util functions Signed-off-by: Huong Nguyen <huongg1409@gmail> * update logic for selector nodes Signed-off-by: Huong Nguyen <huongg1409@gmail> * remove --over-write class on row as it's causing a bug Signed-off-by: Huong Nguyen <huongg1409@gmail> * merge Signed-off-by: Sajid Alam <[email protected]> * Update flowchart.js Signed-off-by: Sajid Alam <[email protected]> * remove overwrite styling as it causing a bug Signed-off-by: Huong Nguyen <huongg1409@gmail> * Revert "Merge branch 'feature/slicing-pipeline--run-command' into feature/slicing-notification" This reverts commit dd0d30b, reversing changes made to 5e02618. * include 2 new props in flowchart test Signed-off-by: Huong Nguyen <huongg1409@gmail> * change the position when meta panel opens Signed-off-by: Huong Nguyen <huongg1409@gmail> * update some colour with the new design changes Signed-off-by: Huong Nguyen <huongg1409@gmail> * selecting a node from bottom to top, the order should not matter Signed-off-by: Sajid Alam <[email protected]> * Update flowchart.js Signed-off-by: Sajid Alam <[email protected]> * center the notification Signed-off-by: Huong Nguyen <huongg1409@gmail> * center the action bar Signed-off-by: Huong Nguyen <huongg1409@gmail> * using existing function to update state Signed-off-by: Huong Nguyen <huongg1409@gmail> * use redux instead of local state Signed-off-by: Huong Nguyen <huongg1409@gmail> * tidy up code Signed-off-by: Sajid Alam <[email protected]> * update colours Signed-off-by: Huong Nguyen <huongg1409@gmail> * only style from to pipeline if both of them are defined Signed-off-by: Huong Nguyen <huongg1409@gmail> * fix the fading styling Signed-off-by: Huong Nguyen <huongg1409@gmail> * add test Signed-off-by: Sajid Alam <[email protected]> * simplify the code Signed-off-by: Huong Nguyen <huongg1409@gmail> * changes based on review Signed-off-by: Sajid Alam <[email protected]> * update variable names Signed-off-by: Huong Nguyen <huongg1409@gmail> * adding comments to explain Signed-off-by: Huong Nguyen <huongg1409@gmail> * rename ActionBar to slicePipelineActionBar Signed-off-by: Sajid Alam <[email protected]> * reorder code Signed-off-by: Huong Nguyen <huongg1409@gmail> * update comment and function name Signed-off-by: Huong Nguyen <huongg1409@gmail> * set minimum transformX value Signed-off-by: Huong Nguyen <huongg1409@gmail> * update function name in test Signed-off-by: Huong Nguyen <huongg1409@gmail> * Adjust the transform value to 0.3s Signed-off-by: Huong Nguyen <huongg1409@gmail> * update config value for calculating postion Signed-off-by: Huong Nguyen <huongg1409@gmail> * update positioning logic Signed-off-by: Huong Nguyen <huongg1409@gmail> * removed unncesscary this.props.slicedPipeline Signed-off-by: Huong Nguyen <huongg1409@gmail> * include extra check for data.name Signed-off-by: Huong Nguyen <huongg1409@gmail> * add || rather than && Signed-off-by: Huong Nguyen <huongg1409@gmail> * add hover style for the slice button Signed-off-by: Huong Nguyen <huongg1409@gmail> * hover style for reset button Signed-off-by: Huong Nguyen <huongg1409@gmail> * hover style for copy button Signed-off-by: Huong Nguyen <huongg1409@gmail> * fix padding for action bar Signed-off-by: Huong Nguyen <huongg1409@gmail> * first working version of box shadow Signed-off-by: Huong Nguyen <huongg1409@gmail> * fix position and transition issue Signed-off-by: Huong Nguyen <huongg1409@gmail> * fix the issue when selecting on the node again the second time Signed-off-by: Huong Nguyen <huongg1409@gmail> * set button heigh and position of the tooltip Signed-off-by: Huong Nguyen <huongg1409@gmail> * update slicing notification when metadata panel is closed Signed-off-by: Sajid Alam <[email protected]> * Update flowchart.js Signed-off-by: Sajid Alam <[email protected]> * remove line at end of notification bar Signed-off-by: Sajid Alam <[email protected]> * persist from node from user selection Signed-off-by: Sajid Alam <[email protected]> * box shadow using after class Signed-off-by: Huong Nguyen <huongg1409@gmail> * fix the from node bug Signed-off-by: Huong Nguyen <huongg1409@gmail> * increase box shadow length Signed-off-by: Huong Nguyen <huongg1409@gmail> * fix bug Signed-off-by: Huong Nguyen <huongg1409@gmail> * update buffer name Signed-off-by: Huong Nguyen <huongg1409@gmail> * update function name Signed-off-by: Huong Nguyen <huongg1409@gmail> * fix merge commit Signed-off-by: Huong Nguyen <huongg1409@gmail> * separate action bar and notification Signed-off-by: Huong Nguyen <huongg1409@gmail> * remove unused mixin Signed-off-by: Huong Nguyen <huongg1409@gmail> * include extra check for run command length Signed-off-by: Huong Nguyen <huongg1409@gmail> * include test for notification Signed-off-by: Huong Nguyen <huongg1409@gmail> * fix bug on highlighting node list in slicing mode Signed-off-by: Huong Nguyen <huongg1409@gmail> * new animation for action bar Signed-off-by: Huong Nguyen <huongg1409@gmail> * fix bug about the number of sliced pipeline Signed-off-by: Huong Nguyen <huongg1409@gmail> * add new props in test Signed-off-by: Huong Nguyen <huongg1409@gmail> * Feature/slicing pipeline add notification (#2003) * change order only when store updated Signed-off-by: Sajid Alam <[email protected]> * update tests Signed-off-by: Sajid Alam <[email protected]> * changes based on review Signed-off-by: Sajid Alam <[email protected]> * Set showSlicingNotification to true if a single node is clicked Signed-off-by: Sajid Alam <[email protected]> * Update flowchart.js Signed-off-by: Sajid Alam <[email protected]> * enable notification when single node is clicked Signed-off-by: Sajid Alam <[email protected]> * Delete sliced-pipeline-action-bar.test.js Signed-off-by: Sajid Alam <[email protected]> * add comments Signed-off-by: Sajid Alam <[email protected]> * merge Signed-off-by: Sajid Alam <[email protected]> --------- Signed-off-by: Sajid Alam <[email protected]> * highlight modularpipeline when collasped in slicing mode Signed-off-by: Huong Nguyen <huongg1409@gmail> * update slice button color Signed-off-by: Huong Nguyen <huongg1409@gmail> * removed unused props Signed-off-by: Huong Nguyen <huongg1409@gmail> * update name for slicePipeline Signed-off-by: Huong Nguyen <huongg1409@gmail> * update test with new name for SET_SLICE_PIPELINE Signed-off-by: Huong Nguyen <huongg1409@gmail> * get runCommand based on type of the element Signed-off-by: Huong Nguyen <huongg1409@gmail> * update run command to get from metadata Signed-off-by: Huong Nguyen <huongg1409@gmail> * add comments Signed-off-by: Huong Nguyen <huongg1409@gmail> * update test for sliced-pipeline Signed-off-by: Huong Nguyen <huongg1409@gmail> * update run-command test with new logic Signed-off-by: Huong Nguyen <huongg1409@gmail> * Disable slicing feature in embedded mode (#2072) * Disable slicing feature in embedded mode Signed-off-by: Jitendra Gundaniya <[email protected]> * test fix Signed-off-by: Jitendra Gundaniya <[email protected]> * Name fix Signed-off-by: Jitendra Gundaniya <[email protected]> * Moved visibleSlicing prop under visible Signed-off-by: Jitendra Gundaniya <[email protected]> * Test fix Signed-off-by: Jitendra Gundaniya <[email protected]> * Remove unused code Signed-off-by: Jitendra Gundaniya <[email protected]> --------- Signed-off-by: Jitendra Gundaniya <[email protected]> * Telemetry/slicing pipeline (#2054) * adding data-test Signed-off-by: Huong Nguyen <huongg1409@gmail> * include getDataTestAttribute Signed-off-by: Huong Nguyen <huongg1409@gmail> --------- Signed-off-by: Huong Nguyen <huongg1409@gmail> Co-authored-by: Huong Nguyen <huongg1409@gmail> * fix the highlight of modular pipeline Signed-off-by: Huong Nguyen <huongg1409@gmail> * fix the position of run command Signed-off-by: Huong Nguyen <huongg1409@gmail> * use 1.5 instead 2 for divided value Signed-off-by: Huong Nguyen <huongg1409@gmail> * Documentation: slicing pipeline in kedro-viz (#2043) * first draft Signed-off-by: Huong Nguyen <huongg1409@gmail> * fix typo Signed-off-by: Huong Nguyen <huongg1409@gmail> * include gif Signed-off-by: Huong Nguyen <huongg1409@gmail> * use uncapital words Signed-off-by: Huong Nguyen <huongg1409@gmail> * remove the word just Signed-off-by: Huong Nguyen <huongg1409@gmail> * remove # Signed-off-by: Huong Nguyen <huongg1409@gmail> * use verb instead of slicing Signed-off-by: Huong Nguyen <huongg1409@gmail> * use stable version Signed-off-by: Huong Nguyen <huongg1409@gmail> * include new gif and increase the size Signed-off-by: Huong Nguyen <huongg1409@gmail> * remove un-used gif Signed-off-by: Huong Nguyen <huongg1409@gmail> * remove ./ in path Signed-off-by: Huong Nguyen <huongg1409@gmail> * revert back to previous syntax Signed-off-by: Huong Nguyen <huongg1409@gmail> * reuploaded gif files Signed-off-by: Huong Nguyen <huongg1409@gmail> * update text Co-authored-by: rashidakanchwala <[email protected]> Signed-off-by: Huong Nguyen <[email protected]> * update text Co-authored-by: rashidakanchwala <[email protected]> Signed-off-by: Huong Nguyen <[email protected]> * update text Co-authored-by: rashidakanchwala <[email protected]> Signed-off-by: Huong Nguyen <[email protected]> * update text Co-authored-by: rashidakanchwala <[email protected]> Signed-off-by: Huong Nguyen <[email protected]> --------- Signed-off-by: Huong Nguyen <huongg1409@gmail> Signed-off-by: Huong Nguyen <[email protected]> Co-authored-by: Huong Nguyen <huongg1409@gmail> Co-authored-by: rashidakanchwala <[email protected]> * update release note Signed-off-by: Huong Nguyen <huongg1409@gmail> --------- Signed-off-by: Huong Nguyen <huongg1409@gmail> Signed-off-by: Sajid Alam <[email protected]> Signed-off-by: Sajid Alam <[email protected]> Signed-off-by: Jitendra Gundaniya <[email protected]> Signed-off-by: Huong Nguyen <[email protected]> Co-authored-by: Huong Nguyen <huongg1409@gmail> Co-authored-by: Sajid Alam <[email protected]> Co-authored-by: Sajid Alam <[email protected]> Co-authored-by: Jitendra Gundaniya <[email protected]> Co-authored-by: rashidakanchwala <[email protected]>

SajidAlamQB changed the title ~~Slicing pipeline add notification~~ Feature/slicing pipeline add notification Jul 26, 2024

SajidAlamQB self-assigned this Jul 26, 2024

SajidAlamQB requested a review from Huongg July 26, 2024 12:58

Huongg reviewed Jul 26, 2024

View reviewed changes

src/components/flowchart/flowchart.js Outdated Show resolved Hide resolved

SajidAlamQB changed the base branch from feature/slicing-pipeline to feature/slicing-pipeline--run-command July 31, 2024 13:48

SajidAlamQB changed the base branch from feature/slicing-pipeline--run-command to feature/slicing-pipeline July 31, 2024 14:09

SajidAlamQB marked this pull request as ready for review August 1, 2024 12:59

SajidAlamQB requested review from rashidakanchwala and jitu5 as code owners August 1, 2024 12:59

Huongg reviewed Aug 5, 2024

View reviewed changes

src/components/flowchart/flowchart.js Show resolved Hide resolved

src/components/flowchart/components/sliced-pipeline-action-bar/sliced-pipeline-action-bar.js Outdated Show resolved Hide resolved

Huongg mentioned this pull request Aug 5, 2024

QA: slicing pipeline feature #2026

Closed

jitu5 reviewed Aug 6, 2024

View reviewed changes

Huongg mentioned this pull request Aug 7, 2024

Feature/slicing pipeline run command #1996

Merged

4 tasks

SajidAlamQB requested review from Huongg and jitu5 August 12, 2024 12:27

Huongg reviewed Aug 12, 2024

View reviewed changes

Huongg mentioned this pull request Aug 12, 2024

Demo slicing pipeline final #2036

Merged

16 tasks

SajidAlamQB added 2 commits August 13, 2024 14:57

change order only when store updated

8b7c8d8

Signed-off-by: Sajid Alam <[email protected]>

update tests

c890945

Signed-off-by: Sajid Alam <[email protected]>

SajidAlamQB requested a review from ravi-kumar-pilla August 13, 2024 14:37

jitu5 approved these changes Aug 13, 2024

View reviewed changes

ravi-kumar-pilla reviewed Aug 14, 2024

View reviewed changes

src/components/flowchart/flowchart.js Outdated Show resolved Hide resolved

changes based on review

6324e1d

Signed-off-by: Sajid Alam <[email protected]>

Set showSlicingNotification to true if a single node is clicked

2e62a58

Signed-off-by: Sajid Alam <[email protected]>

Update flowchart.js

4279a82

Signed-off-by: Sajid Alam <[email protected]>

ravi-kumar-pilla self-requested a review August 15, 2024 17:10

ravi-kumar-pilla approved these changes Aug 15, 2024

View reviewed changes

SajidAlamQB changed the base branch from feature/slicing-pipeline to demo-slicing-pipeline-final August 15, 2024 17:20

SajidAlamQB added 5 commits August 15, 2024 18:54

Merge branch 'demo-slicing-pipeline-final' into feature/slicing-notif…

cee952a

…ication Signed-off-by: Sajid Alam <[email protected]>

enable notification when single node is clicked

f80684c

Signed-off-by: Sajid Alam <[email protected]>

Delete sliced-pipeline-action-bar.test.js

87cdae4

Signed-off-by: Sajid Alam <[email protected]>

add comments

0ec2d68

Signed-off-by: Sajid Alam <[email protected]>

merge

0275ed6

Signed-off-by: Sajid Alam <[email protected]>

SajidAlamQB merged commit a5bb98c into demo-slicing-pipeline-final Aug 16, 2024
4 checks passed

SajidAlamQB deleted the feature/slicing-notification branch August 16, 2024 09:18

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/slicing pipeline add notification #2003

Feature/slicing pipeline add notification #2003

SajidAlamQB commented Jul 26, 2024 •

edited by Huongg

Loading

Huongg left a comment •

edited

Loading

SajidAlamQB commented Aug 7, 2024

Huongg commented Aug 7, 2024

stephkaiser commented Aug 8, 2024 •

edited

Loading

Huongg left a comment

jitu5 commented Aug 13, 2024

Huongg commented Aug 13, 2024

jitu5 commented Aug 13, 2024

jitu5 left a comment

Huongg commented Aug 13, 2024

ravi-kumar-pilla commented Aug 15, 2024

SajidAlamQB commented Aug 15, 2024

ravi-kumar-pilla left a comment

Feature/slicing pipeline add notification #2003

Feature/slicing pipeline add notification #2003

Conversation

SajidAlamQB commented Jul 26, 2024 • edited by Huongg Loading

Description

Development notes

Checklist

Huongg left a comment • edited Loading

Choose a reason for hiding this comment

SajidAlamQB commented Aug 7, 2024

Huongg commented Aug 7, 2024

stephkaiser commented Aug 8, 2024 • edited Loading

Huongg left a comment

Choose a reason for hiding this comment

jitu5 commented Aug 13, 2024

Huongg commented Aug 13, 2024

jitu5 commented Aug 13, 2024

jitu5 left a comment

Choose a reason for hiding this comment

Huongg commented Aug 13, 2024

ravi-kumar-pilla commented Aug 15, 2024

SajidAlamQB commented Aug 15, 2024

ravi-kumar-pilla left a comment

Choose a reason for hiding this comment

SajidAlamQB commented Jul 26, 2024 •

edited by Huongg

Loading

Huongg left a comment •

edited

Loading

stephkaiser commented Aug 8, 2024 •

edited

Loading