Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/gitpod #1862

Merged
merged 25 commits into from
Apr 18, 2024
Merged
Show file tree
Hide file tree
Changes from 19 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .gitpod.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
image: gitpod/workspace-full:2023-01-16-03-31-28
image: gitpod/workspace-full:2023-09-29-11-03-42

Huongg marked this conversation as resolved.
Show resolved Hide resolved
tasks:
- name: frontend
init: |
Expand All @@ -14,7 +14,7 @@ tasks:
- name: backend
before: echo PIP_USER=no >> ~/.bashrc && export PIP_USER=no
init: |
pip install "pip==23.0.1" --user
pip install "pip==23.3.1" --user
pip install -r package/test_requirements.txt -r demo-project/src/docker_requirements.txt --user
# Install latest kedro and all its dependencies.
pip install https://github.com/kedro-org/kedro/archive/main.zip --user
Expand Down
15 changes: 15 additions & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -318,6 +318,21 @@ Python dependencies in Kedro-Viz are usually updated automatically through tools

If the lower-bound e2e test fails, it indicates that some dependencies may not work correctly with Kedro-Viz. To resolve this, update the problematic dependency in both `requirements.txt` and `lower-requirements.txt`.

### Testing UI using Gitpod
Huongg marked this conversation as resolved.
Show resolved Hide resolved
**1. Once you open a Pull request, click on the Open icon on the right**
Huongg marked this conversation as resolved.
Show resolved Hide resolved
<img width="1510" alt="Screenshot 2024-04-17 at 15 54 36" src="https://github.com/kedro-org/kedro-viz/assets/32060364/4295e00f-f80d-46e5-bb19-336e393f00a5">


**2. It will open the gitpod workspace automatically**
<img width="1792" alt="Screenshot 2024-04-17 at 15 57 41" src="https://github.com/kedro-org/kedro-viz/assets/32060364/9aea0174-858a-4ebc-9c62-ee90b28c921f">

**3. Please wait until both FE and BE are done with their build. You can check it by clicking on `frontend` and `backend`. This can take around 5 minutes to fully finish**
Huongg marked this conversation as resolved.
Show resolved Hide resolved
<img width="1455" alt="Screenshot 2024-04-17 at 15 59 46" src="https://github.com/kedro-org/kedro-viz/assets/32060364/ae080672-4a48-4178-b83e-70274071497f">
<img width="1456" alt="Screenshot 2024-04-17 at 16 04 38" src="https://github.com/kedro-org/kedro-viz/assets/32060364/af60ea0a-6148-4354-938e-3a0ef7b9e711">

**4. Final step is to ensure that you unblock the pop-up ads in the browser, then refresh the browser again. It should then build the kedro-viz in gitpod workspace**
Huongg marked this conversation as resolved.
Show resolved Hide resolved
<img width="1432" alt="Screenshot 2024-04-17 at 16 06 05" src="https://github.com/kedro-org/kedro-viz/assets/32060364/53dd56c2-df5e-49a6-ba06-9846af7bab52">

# Release guidelines

- Practice frequent, staggered releases.
Expand Down
7 changes: 7 additions & 0 deletions RELEASE.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,13 @@ Please follow the established format:
- Use present tense (e.g. 'Add new feature')
- Include the ID number for the related PR (or PRs) in parentheses
-->
# Next release

## Major features and improvements

## Bug fixes and other changes
- Upgrade the gitpod workspace-full to a newer version which includes both Node 18 and Python 3.12. (#1862)

# Release 9.0.0

## Major features and improvements
Expand Down
Loading