-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Experiment] Show/Hide Memory Datasets on the flowchart #1707
Conversation
What happens to nodes which only have memory datasets as inputs and outputs? just a line connecting them to the last dataset which isn't memory? |
This is a great feature to show/hide dataset types reducing the size of the flowchart. I have concerns over the placement of Memory Datasets under Element Types. It would be nice to have a hierarchy where these fall under Datasets. |
Would this just be for |
For the purposes of this experiment I think |
Unpopular opinion and this is already fantastic work but 2 thoughts. I dont see why this feature will be super impactful. Would love to hear your thoughts.
If the goal is to signal users that these datasets use cache or inmemory storage and not persisted storage , i would create a tooltip or a separate action to explain datasets (all datasets) . Something that on hovering gives basic information about the datasets like
WDYT ? |
If we are just discussing the idea, I like it (although I like #1706 more). Going a bit beyond, I have the same question as @merelcht:
Currently this PR introduces some coupling between the frontend and the dataset names, which as far as I understand goes against the idea of #1698 (although this PR is more concerned with the backend). Moreover, it's not even complete, because what if the user defines another non persistent dataset? Wondering if this use case could be solved by letting the user configure the appearance of certain types of nodes in general, some sort of "style mapping" or even custom CSS rules. |
Hey, there would be line connecting the two task/function nodes. Below is an example of Memory Dataset shown and then hidden (Split Data --> Train Evaluation) On second thoughts, I too find this show/hide a bit misleading, I would rather do #1706 then hide them completely. |
I think it might be nice to have more powerful, persistent exclusion functionality - but I agree that #1706 is better. Again pointing to dbt, they have an ability for the user to provide custom colors - a long time ago I pitched #480 which was turned into #1148 but hasn't been prioritised. |
One more solution could be
That covers the memory dataset but also makes the approach more open to other dataset types. |
Closing this experiment PR for now -- allowing users to differentiating datasets on kedro-viz seems like a good idea. We are going to try and do #1148 first and see how that picks up with users. |
Description
Related to #1706. should we provide users with the option to display or hide Memory Datasets in the view? This feature can be particularly helpful for larger and more complex pipelines. This PR offers an experimental toggle to show/hide Memory Datasets, functioning similarly to the show/hide dataset.
This is currently not under experiment flag.
Development notes
QA notes
Checklist
RELEASE.md
file